NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

bpo-44136: pathlib: merge`_Flavour.make_uri()` into`PurePath.as_uri()`#30320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

barneygale wants to merge2 commits intopython:mainfrombarneygale:bpo-44136-merge-as-uri

Closed

bpo-44136: pathlib: merge`_Flavour.make_uri()` into`PurePath.as_uri()`#30320

barneygale wants to merge2 commits intopython:mainfrombarneygale:bpo-44136-merge-as-uri

Conversation

Copy link

Contributor

barneygale commentedJan 1, 2022•
edited by bedevere-bot
Loading

Removes a bit of indirection.

https://bugs.python.org/issue44136

bpo-44136: pathlib: merge_Flavour.make_uri() intoPurePath.as_uri()

e3c29f7

Removes a bit of indirection.

the-knights-who-say-ni added the CLA signed label

Jan 1, 2022

bedevere-bot added the awaiting review label

Jan 1, 2022

Copy link

github-actionsbot commentedFeb 1, 2022

This PR is stale because it has been open for 30 days with no activity.

github-actionsbot added the staleStale PR or inactive for long period of time. label

Feb 1, 2022

Delete duplicated docstring

94c41e5

barneygale mentioned this pull request

Feb 21, 2022

bpo-24132: Addpathlib._AbstractPath#31085

Closed

brettcannon self-requested a review

February 22, 2022 23:33

brettcannon added the skip news label

Feb 25, 2022

brettcannon closed this

Feb 25, 2022

brettcannon reopened this

Feb 25, 2022

MaxwellDupre approved these changes

Feb 26, 2022

View reviewed changes

Copy link

Contributor

MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks ok to me.

bedevere-bot added awaiting core review and removed awaiting review labels

Feb 26, 2022

Copy link

Member

brettcannon commentedMar 4, 2022

So why do this? I noticedas_uri() wasn't moved underPurePosixPath, so why the half move? And what's going to be gained by doing this? I know the issue mentioned potential future benefits, but I would rather make the actual change with the future benefit rather than in hopes of the benefit materializing.

Basically the code doesn't read any simpler/cleaner, and withPurePosixPath not changed I'm not finding it more readable, so it feels a bit too much like code churn without understanding the deeper motivation.