Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-38085: Fix throw exception in __init__subclass__ causes wrong isinstance() a…#30112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
hongweipeng wants to merge4 commits intopython:main
base:main
Choose a base branch
Loading
fromhongweipeng:abc-init-subclass-exception

Conversation

hongweipeng
Copy link
Contributor

@hongweipenghongweipeng commentedDec 15, 2021•
edited by bedevere-bot
Loading

…nd issubclass() results in subclasses of abc.ABCMeta.

https://bugs.python.org/issue38085

…nd issubclass() results in subclasses of abc.ABCMeta.
@cfbolz
Copy link
Contributor

see my comments on the issue. imo this is solving the symptom of the problem, but not the root problem, which is that a broken class appears in its base classes.__subclasses__() list.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelJan 24, 2022
Copy link
Contributor

@MaxwellDupreMaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me. All tests passed for me:
./python -m test -v test_abc
Ran 72 tests in 0.019s
OK
== Tests result: SUCCESS ==
1 test OK.
Total duration: 96 ms
Tests result: SUCCESS
cpython on  abc-init-subclass-exception [$] via 🐍 v3.11.0a3+

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@MaxwellDupreMaxwellDupreMaxwellDupre approved these changes

@markshannonmarkshannonAwaiting requested review from markshannon

Assignees
No one assigned
Labels
awaiting core reviewstaleStale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@hongweipeng@cfbolz@MaxwellDupre@the-knights-who-say-ni@ezio-melotti@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp