Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
bpo-45953: Statically allocate and initialize global bytes objects.#30096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
bpo-45953: Statically allocate and initialize global bytes objects.#30096
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A few quibbles, otherwise looks good.
Uh oh!
There was an error while loading.Please reload this page.
.ob_shash = -1, \ | ||
.ob_sval[0] = '\0', \ | ||
} | ||
#define _PyBytes_CHAR_INIT(CH) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is a declaration, not initialization code. Maybe rename to_PyBytes_CHAR
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I was sticking to the_INIT
convention used elsewhere.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
The empty bytes object (
b''
) and the 256 one-character bytes objects are allocated at runtime init. Here we statically allocate and initialize them.https://bugs.python.org/issue45953