Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
bpo-45953: Statically initialize the small ints.#30092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ericsnowcurrently merged 12 commits intopython:mainfromericsnowcurrently:global-objects-small-intsDec 14, 2021
Merged
bpo-45953: Statically initialize the small ints.#30092
ericsnowcurrently merged 12 commits intopython:mainfromericsnowcurrently:global-objects-small-intsDec 14, 2021
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
gvanrossum approved these changesDec 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. I have a nit in a comment but it was present in the original before the move as well.
Uh oh!
There was an error while loading.Please reload this page.
a20f308 to8f10ad0CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The array of small
PyLongobjects has been statically declared. Here I also statically initialize them. Consequently they are no longer initialized dynamically during runtime init.I've also moved them under a new sub-struct in
_PyRuntimeState, in preparation for static allocation and initialization of other global objects.FWIW, I considered adding a script for generating the array initializer, but figured that can be done separately if valuable.
https://bugs.python.org/issue45953