NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

bpo-45997: Fix asyncio.Semaphore waiters order#30052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

hyzyla wants to merge1 commit intopython:mainfromhyzyla:add-asyncio-semaphore-order

Closed

bpo-45997: Fix asyncio.Semaphore waiters order#30052

hyzyla wants to merge1 commit intopython:mainfromhyzyla:add-asyncio-semaphore-order

Conversation

Copy link

hyzyla commentedDec 11, 2021•
edited by bedevere-bot
Loading

Allow other Semaphore waiters to acquire lock after releasing by current coroutine by skipping one event loop iteration. If everything is OK for Semaphore, I can add the same logic to other asyncio synchronization primitives

https://bugs.python.org/issue45997

bpo-45997: Fix asyncio.Semaphore waiters order

930228a

hyzyla requested review from1st1 andasvetlov ascode owners

December 11, 2021 14:42

Copy link

the-knights-who-say-ni commentedDec 11, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed thePSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find abugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@hyzyla

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please followthe steps outlined in the CPython devguide to rectify this issue.

You cancheck yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

the-knights-who-say-ni added the CLA not signed label

Dec 11, 2021

bedevere-bot added the awaiting review label

Dec 11, 2021

asvetlov requested changes

Dec 14, 2021

View reviewed changes

Copy link

Contributor

asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The PR adds unconditional sleep even if the waiting is not needed (the context was switched already).
I think we need an alternative implementation based on future object waiting.

bedevere-bot added awaiting changes and removed awaiting review labels

Dec 14, 2021

Copy link

bedevere-bot commentedDec 14, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link

github-actionsbot commentedJan 14, 2022

This PR is stale because it has been open for 30 days with no activity.

github-actionsbot added the staleStale PR or inactive for long period of time. label

Jan 14, 2022

Copy link

Contributor

taleinat commentedJan 18, 2022•
edited
Loading

@hyzyla, are you interested in continuing to work on this PR following@asvetlov's comment?

(If so, you will need to to sign the CLA.)

github-actionsbot removed the staleStale PR or inactive for long period of time. label

Jan 19, 2022

Copy link

Author

hyzyla commentedJan 19, 2022

I would like to return to PR in few weeks, I have idea where I will create Future, then will put it to loop via call_soon and in the end in acquire method waiting for that Future