NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

bpo-46038: Mark /configure file as generated in .gitattributes#30031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

arhadthedev wants to merge2 commits intopython:mainfromarhadthedev:collapse-configure-in-pr

Closed

bpo-46038: Mark /configure file as generated in .gitattributes#30031

arhadthedev wants to merge2 commits intopython:mainfromarhadthedev:collapse-configure-in-pr

Conversation

Copy link

Member

arhadthedev commentedDec 10, 2021•
edited by bedevere-bot
Loading

configure is regenerated from configure.ac using a custom container with appropriate version of tools (quay.io/tiran/cpython_autoconf by Christian Heimes). As a result, configure falls into the same category as files generated by Argument Clinic, Freeze and Parser/asdl_c.py. Due to size and churn of these artifacts, they are marked in .gitattributes as generated so GitHub Pull Request Diff Viewer collapses them into a short notification. This pull request does the same for configure.

Actually, configure diff is so large that sometimes it crosses a threshold and GitHub collapses it by force with "Large diffs are not rendered by default" or even "xxx additions, yyy deletions not shown because the diff is too large. Please use a local Git client to view these changes". SeeGH-29756 as an extreme example andhttps://github.com/python/cpython/commits/main/configure for an average.

I believe this PR does not need a NEWS entry because the change is relevant only for a GitHub-hosted copy.

https://bugs.python.org/issue46038

Mark configure file as generated in .gitattributes

85968c3

configure is regenerated from configure.ac using a custom containerwith appropriate version of tools (quay.io/tiran/cpython_autoconfby Christian Heimes).As a result, configure falls into the same category as files generatedby Argument Clinic, Freeze and Parser/asdl_c.py. Due to size and churnof these artifacts, they are marked in .gitattributes as generated soGitHub Pull Request Diff Viewer collapses them into a shortnotification. This commit does the same for configure.Actually, configure diff is so large that sometimes it crossesa threshold and GitHub collapses it by force with "Large diffs are notrendered by default" or even "xxx additions, yyy deletions not shownbecause the diff is too large. Please use a local Git client to viewthese changes". SeepythonGH-29756 as an extreme example and<https://github.com/python/cpython/commits/main/configure> foran average.