Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-89886: Clean up MACHDEP and _PYTHON_HOST_PLATFORM checks#30026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
erlend-aasland wants to merge4 commits intopython:mainfromerlend-aasland:ac-stuff

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedDec 10, 2021
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commentedDec 10, 2021
edited
Loading

If When the basic CI passes, I'll send it to the bots.

@tiran
Copy link
Member

There is no CI for cross building yet.

@erlend-aasland
Copy link
ContributorAuthor

There is no CI for cross building yet.

Let's run it on the Emscripten container then; that's a cross-build, AFAIU.

@erlend-aasland
Copy link
ContributorAuthor

Accidentally, I've got some ARM toolchains installed. I'll throw it at them and see how it fares.

@arhadthedev
Copy link
Member

Just out of curiosity: what distributions still don't have Autoconf so we need pregeneratedconfigure under version control? Won't it be better to let a user or a package manager to generate it on their system instead?

@tiran
Copy link
Member

Package managers are not our concern. We keep configure and other scripts in git to lower the barrier for contributors.

Ourconfigure.ac more than just autotools. It also requires automake, a recent version of autoconf-archive and pkg-config's M4 macros. Not every distro has a recent enough autoconf archive package. Some distros have the pkg-config M4 files in a separate package. Until a couple of weeks ago ourconfigure.ac did not work with autoconf 2.71.

erlend-aasland and arhadthedev reacted with thumbs up emoji

@arhadthedev
Copy link
Member

Well, if this file cannot be removed because of specific requirements for its generation, maybe it can be marked as generated akin to outputs of Argument Clinic, Freeze, and Parser/asdl_c.py? It will allow GitHub to collapse it. By the way, I created#30031 to address this.

erlend-aasland reacted with thumbs up emoji

@erlend-aasland
Copy link
ContributorAuthor

BTW, this is a case where theconfigure diff matters at little bit more than normal: we have no CI for changes like this, so being able to see that the refactored code actually produces the same result is crucial. Luckily, this diff is pretty short 🙂

@erlend-aasland
Copy link
ContributorAuthor

Accidentally, I've got some ARM toolchains installed. I'll throw it at them and see how it fares.

Works for me.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelJan 23, 2022
Copy link
Contributor

@MaxwellDupreMaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

From the number of tests passed on my machine (420) I would say this looks ok to me.
But I cant test for all the supported architectures.
Also, I saw 61fatal error in theconfig.log.
Is this ok?
BTW how do you check the results on configure? A part from running full test suite and checking the log.

@erlend-aaslanderlend-aasland changed the titlebpo-45723: Clean up MACHDEP and _PYTHON_HOST_PLATFORM checksbpo-89886: Clean up MACHDEP and _PYTHON_HOST_PLATFORM checksApr 10, 2022
@erlend-aasland
Copy link
ContributorAuthor

I have no time to follow up this clean-up. Closing.

@erlend-aaslanderlend-aasland deleted the ac-stuff branchJune 27, 2022 08:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@MaxwellDupreMaxwellDupreMaxwellDupre approved these changes

@tirantiranAwaiting requested review from tiran

Assignees
No one assigned
Labels
awaiting core reviewskip newsstaleStale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@erlend-aasland@tiran@arhadthedev@MaxwellDupre@the-knights-who-say-ni@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp