Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-24301: Do not fail when gzip files have trailing garbage#29847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
rhpvorderman wants to merge3 commits intopython:main
base:main
Choose a base branch
Loading
fromrhpvorderman:bpo-24301

Conversation

rhpvorderman
Copy link
Contributor

@rhpvordermanrhpvorderman commentedNov 29, 2021•
edited by bedevere-bot
Loading

Apparently thegzip command line utility and several others display the same behaviour. Python failing here is unexpected.

The code was adapted so that trailing garbage emits a warning (just like the gzip cli). The first member is still checked for a correct magic number.

https://bugs.python.org/issue24301

jeremytwfortune reacted with hooray emoji
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelDec 30, 2021
Copy link
Contributor

@MaxwellDupreMaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you add to docs, please?
I think its important users know what to expect. Does't need much, similar to what you have in NEWS.

@rhpvorderman
Copy link
ContributorAuthor

@MaxwellDupre I added some..versionchanged notes. Is that what you had in mind?

@python-cla-bot
Copy link

python-cla-botbot commentedApr 18, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@MaxwellDupreMaxwellDupreMaxwellDupre requested changes

Assignees
No one assigned
Labels
awaiting core reviewstaleStale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@rhpvorderman@MaxwellDupre@the-knights-who-say-ni@ezio-melotti@bedevere-bot@hauntsaninja
[8]ページ先頭
©2009-2025 Movatter.jp