Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-45881: configure --with-freeze-module --with-build-python (GH-29835)#29835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tiran merged 7 commits intopython:mainfromtiran:bpo-45881-cross-freeze
Nov 29, 2021

Conversation

tiran
Copy link
Member

@tirantiran commentedNov 29, 2021•
edited by bedevere-bot
Loading

Make cross compiling more convenient. configure now takes
--with-freeze-module and--with-build-python arguments. There is
no need passFREEZE_MODULE andPYTHON_FOR_BUILD env vars any
more.

Signed-off-by: Christian Heimeschristian@python.org

https://bugs.python.org/issue45881

@tiran
Copy link
MemberAuthor

tiran commentedNov 29, 2021•
edited
Loading

@ethanhs

This changeset makes our configure call easier: emconfigure ../../configure -C --with-freeze-module=$(pwd)/../build/Programs/_freeze_module --with-build-python=$(pwd)/../build/python

  • improve help strings
  • write documentation
  • adds blurb
emmatyping reacted with hooray emoji

Copy link
Member

@emmatypingemmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have a bunch of minor nits but overall this looks good! I also think we should be strict in checking that the Python version used for _freeze_module is the same as the host Python.

@tirantiranforce-pushed thebpo-45881-cross-freeze branch from772abec to7fbc2b4CompareNovember 29, 2021 15:30
@tirantiran marked this pull request as ready for reviewNovember 29, 2021 15:31
tiranand others added7 commitsNovember 29, 2021 16:34
Make cross compiling more convenient. configure now takes``--with-freeze-module`` and ``--with-build-python`` arguments. There isno need pass ``FREEZE_MODULE`` and ``PYTHON_FOR_BUILD`` env vars anymore.Signed-off-by: Christian Heimes <christian@python.org>
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Co-authored-by: Ethan Smith <ethan@ethanhs.me>
Co-authored-by: Ethan Smith <ethan@ethanhs.me>
Co-authored-by: Ethan Smith <ethan@ethanhs.me>
@tirantiranforce-pushed thebpo-45881-cross-freeze branch from158a573 toe4eff12CompareNovember 29, 2021 15:34
@tirantiran changed the titlebpo-45881: configure --with-freeze-module --with-build-pythonbpo-45881: configure --with-freeze-module --with-build-python (GH-29835)Nov 29, 2021
@tirantiran merged commit992565f intopython:mainNov 29, 2021
@tirantiran deleted the bpo-45881-cross-freeze branchNovember 29, 2021 16:23
tiran added a commit to tiran/python-wasm that referenced this pull requestNov 29, 2021
See:python/cpython#29835Signed-off-by: Christian Heimes <christian@python.org>
shihai1991 added a commit to shihai1991/cpython that referenced this pull requestDec 1, 2021
* main: (21 commits)  bpo-45876:  Have stdev() also use decimal specific square root. (pythonGH-29869)  bpo-45876:  Correctly rounded stdev() and pstdev() for the Decimal case (pythonGH-29828)  bpo-45711: Change exc_info related APIs to derive type and traceback from the exception instance (pythonGH-29780)  bpo-30533:Add function inspect.getmembers_static that does not call properties or dynamic properties. (python#20911)  bpo-45476: Disallow using asdl_seq_GET() as l-value (pythonGH-29866)  bpo-45476: Add _Py_RVALUE() macro (pythonGH-29860)  bpo-33381: [doc] strftime's %f option may pad zeros on the left or the right (pythonGH-29801)  Fix EncodingWarning in Tools/freeze/test/freeze.py (pythonGH-29742)  no-issue: remove unused import from test_graphlib.py (pythonGH-29853)  bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (pythonGH-29854)  bpo-45653: fix test_embed on windows (pythonGH-29814)  bpo-45917: Add math.exp2() method - return 2 raised to the power of x (pythonGH-29829)  bpo-43905: Expand dataclasses.astuple() and asdict() docs (pythonGH-26154)  bpo-44391: Remove unused argument from a varargs call. (pythonGH-29843)  bpo-45881: configure --with-freeze-module --with-build-python (pythonGH-29835)  bpo-45847: PY_STDLIB_MOD_SIMPLE now checks py_stdlib_not_available (pythonGH-29844)  bpo-45828: Use unraisable exceptions within sqlite3 callbacks (FH-29591)  bpo-40280: Emscripten systems use .wasm suffix by default (pythonGH-29842)  bpo-45723: Sort the grand AC_CHECK_HEADERS check (pythonGH-29846)  bpo-45847: Make socket module conditional (pythonGH-29769)  ...
shihai1991 added a commit to shihai1991/cpython that referenced this pull requestDec 1, 2021
* main: (21 commits)  bpo-45876:  Have stdev() also use decimal specific square root. (pythonGH-29869)  bpo-45876:  Correctly rounded stdev() and pstdev() for the Decimal case (pythonGH-29828)  bpo-45711: Change exc_info related APIs to derive type and traceback from the exception instance (pythonGH-29780)  bpo-30533:Add function inspect.getmembers_static that does not call properties or dynamic properties. (python#20911)  bpo-45476: Disallow using asdl_seq_GET() as l-value (pythonGH-29866)  bpo-45476: Add _Py_RVALUE() macro (pythonGH-29860)  bpo-33381: [doc] strftime's %f option may pad zeros on the left or the right (pythonGH-29801)  Fix EncodingWarning in Tools/freeze/test/freeze.py (pythonGH-29742)  no-issue: remove unused import from test_graphlib.py (pythonGH-29853)  bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (pythonGH-29854)  bpo-45653: fix test_embed on windows (pythonGH-29814)  bpo-45917: Add math.exp2() method - return 2 raised to the power of x (pythonGH-29829)  bpo-43905: Expand dataclasses.astuple() and asdict() docs (pythonGH-26154)  bpo-44391: Remove unused argument from a varargs call. (pythonGH-29843)  bpo-45881: configure --with-freeze-module --with-build-python (pythonGH-29835)  bpo-45847: PY_STDLIB_MOD_SIMPLE now checks py_stdlib_not_available (pythonGH-29844)  bpo-45828: Use unraisable exceptions within sqlite3 callbacks (FH-29591)  bpo-40280: Emscripten systems use .wasm suffix by default (pythonGH-29842)  bpo-45723: Sort the grand AC_CHECK_HEADERS check (pythonGH-29846)  bpo-45847: Make socket module conditional (pythonGH-29769)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@emmatypingemmatypingemmatyping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@tiran@emmatyping@erlend-aasland@the-knights-who-say-ni@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp