NotificationsYou must be signed in to change notification settings
Fork32k
Star67.2k

bpo-18717: Add test for request.urlretrieve#29822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

180909 wants to merge2 commits intopython:main

base:main

Choose a base branch

from180909:fix-issue-18717

Open

bpo-18717: Add test for request.urlretrieve#29822

180909 wants to merge2 commits intopython:mainfrom180909:fix-issue-18717

+13 −0

Conversation

Copy link

Contributor

180909 commentedNov 28, 2021•
edited by bedevere-bot
Loading

https://bugs.python.org/issue18717

180909 added2 commits

November 28, 2021 22:23

bpo-18717: Add test for request.urlretrieve

c408808

update NEWS.d

1c42d32

bedevere-bot added the testsTests in the Lib/test dir label

Nov 28, 2021

the-knights-who-say-ni added the CLA signed label

Nov 28, 2021

bedevere-bot added the awaiting review label

Nov 28, 2021

Copy link

github-actionsbot commentedDec 29, 2021

This PR is stale because it has been open for 30 days with no activity.

github-actionsbot added the staleStale PR or inactive for long period of time. label

Dec 29, 2021

ezio-melotti removed the CLA signed label

Jul 13, 2022

mjehanzebmannequin mentioned this pull request

Apr 10, 2022

test for request.urlretrieve#62917

Open

serhiy-storchaka requested changes

Feb 28, 2024

View reviewed changes

Copy link

Member

serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

urllib.request tests that use network should be intest_urllibnet.py ortest_urllib2net.py. Or intest_urllib2_localnet.py if they only use the local network.

And the tests should be more complicated. See#62917 (comment) for my suggestions.

bedevere-appbot added awaiting changes and removed awaiting review labels

Feb 28, 2024

Copy link

bedevere-appbot commentedFeb 28, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.