Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-89769: Pathlib - do not follow links when checking for precise glob match#29655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

akulakov
Copy link
Contributor

@akulakovakulakov commentedNov 20, 2021•
edited by bedevere-bot
Loading

https://bugs.python.org/issue45606

I've also added afollow_symlinks arg toexists() method because it seems more logical to be able to test if a path exists via the same method rather than having to also remember and to check for it being a symlink. This is also consistent with a few otherPath methods; and it makes it more explicit and clearer that by defaultexists() follows symlinks, by looking at its signature (otherwise this may be a surprising behaviour).

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelDec 21, 2021
Copy link
Contributor

@MaxwellDupreMaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Works on my Ubuntu and I see bot tests are ok, so ok with me.

Copy link
Contributor

@barneygalebarneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Change looks good! Could you fix conflicts please?

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@barneygalebarneygale changed the titlebpo-45606: Pathlib - do not follow links when checking for precise glob matchGH-89769: Pathlib - do not follow links when checking for precise glob matchMay 2, 2023
akulakovand others added5 commitsMay 2, 2023 21:53
Co-authored-by: Barney Gale <barney.gale@gmail.com>
Co-authored-by: Barney Gale <barney.gale@gmail.com>
Co-authored-by: Barney Gale <barney.gale@gmail.com>
Co-authored-by: Barney Gale <barney.gale@gmail.com>
Copy link
Contributor

@barneygalebarneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Last nit. Thanks!

@barneygalebarneygale removed the staleStale PR or inactive for long period of time. labelMay 3, 2023
@barneygalebarneygale merged commitaf886ff intopython:mainMay 3, 2023
@barneygale
Copy link
Contributor

Thanks again,@akulakov

@akulakov
Copy link
ContributorAuthor

Thanks@barneygale for the review and merging!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ambvambvambv left review comments

@barneygalebarneygalebarneygale approved these changes

@MaxwellDupreMaxwellDupreMaxwellDupre approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8 participants
@akulakov@bedevere-bot@barneygale@ambv@MaxwellDupre@brettcannon@the-knights-who-say-ni@ezio-melotti
[8]ページ先頭
©2009-2025 Movatter.jp