Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-42238: [doc]: Hide false positive in make suspicious.#29636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 1 commit intopython:mainfromJulienPalard:mdk-suspicious
Nov 19, 2021

Conversation

JulienPalard
Copy link
Member

@JulienPalardJulienPalard commentedNov 19, 2021
edited by bedevere-bot
Loading

@JulienPalard
Copy link
MemberAuthor

Original PR (#29389) has been backported to 3.9 and 3.10 so I'll backport this to 3.9 and 3.10 too.

@AlexWaygood
Copy link
Member

Original PR (#29389) has been backported to 3.9 and 3.10 so I'll backport this to 3.9 and 3.10 too.

I think@ambv already applied this to 3.9/3.10:

(Sorry for the bother — thanks for fixing!)

@ambvambv removed needs backport to 3.9only security fixes needs backport to 3.10only security fixes labelsNov 19, 2021
@ambv
Copy link
Contributor

@JulienPalard, since we're no longer runningmake suspicious in CI formain per your own change (GH-26575), should we just stop caring aboutmake suspicious at all?

@ambvambv merged commitd32316a intopython:mainNov 19, 2021
@JulienPalardJulienPalard deleted the mdk-suspicious branchNovember 20, 2021 00:58
@JulienPalard
Copy link
MemberAuthor

JulienPalard commentedNov 20, 2021
edited by bedevere-bot
Loading

@JulienPalard, since we're no longer runningmake suspicious in CI formain per your own change (GH-26575), should we just stop caring aboutmake suspicious at all?

Soon, yes. The idea is I'm tracking closelymake suspicious inbpo-42238 to see if there's true positives that I can implement inrstlint.py. It allowed me to add a few new things in rstlint:

and we do ensure rstlint in the CI as it make no false positives.

So « soon » rstlint should catch all the true positives of make suspicious, leaving only false positives formake suspicious.

This day I'll just drop it, and really stop caring about it.

Up to this day I prefer having an up-to-datesusp-ignored.csv, so I can easily monitor new alerts.

@JulienPalard
Copy link
MemberAuthor

(But I only watch master so backporting can be ignored, yes)

@AlexWaygood
Copy link
Member

and we do ensure rstlint in the CI as it make no false positives.

Arguably rstlintdid have a few false positives in this PR 🙂 (but maybe I'm just too backtick-happy!)

@JulienPalard
Copy link
MemberAuthor

Arguably rstlintdid have a few false positives in this PR slightly_smiling_face (but maybe I'm just too backtick-happy!)

This is a really interesting information, TIL, thanks! I'll have to look at it :D

AlexWaygood reacted with heart emoji

remykarem pushed a commit to remykarem/cpython that referenced this pull requestDec 7, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@JulienPalard@AlexWaygood@ambv@the-knights-who-say-ni@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp