Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
bpo-45837: Properly deprecate turtle.RawTurtle.settiltangle#29618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
c145b3b to10809f3Compare@hugovk would be great if you created a 3.10 and 3.9 PR that only clarifies in its docstring that |
This was referencedNov 18, 2021
MemberAuthor
hugovk commentedNov 18, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
No, they don't. Thanks, Hugo! All merged. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
turtle's
settiltanglewas deprecated in Python 3.1, according todocs:And thereason:
However, indocstrings,
tiltanglewas accidentally commented as deprecated:Neither
tiltanglenorsettiltangleraiseDeprecationWarnings.So let's:
tiltangle's docstring to say it's not really deprecatedsettiltangle's docstring to say it's deprecatedDeprecationWarningtosettiltangleself.tiltangleinstead ofself.settiltangleBPO references:
2009https://bugs.python.org/issue5923 - when
settiltanglewas originally deprecated, with rationale.2010https://bugs.python.org/issue7888 - the deprecation mixup was discovered and apparently corrected in py3k and release31-maint. I've not done the SCM archaeology to discover why this didn't make it through!
2020https://bugs.python.org/issue41165 - both mentioned as deprecated, discrepancy not noted.
https://bugs.python.org/issue45837