Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-45753: Interpreter internal tweaks#29575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

markshannon
Copy link
Member

@markshannonmarkshannon commentedNov 16, 2021
edited
Loading

The overall purpose of this PR is to help future work on inter-bytecode optimization and efficient support for tracing events.

This is a bit of an ugly PR as it attempts to do a few things which are conceptually only loosely related, but are interwoven in the code.

  1. Specify a set of interpreter "registers", that is the parts of the interpreter state that are worth caching in local variables. This is nothing new, just a bit more explicit. These variables are currently:
  2. Make all tracing events explicit as macros, and move them into instructions where appropriate.
  3. Inline frame exit, entry and resumption where necessary to support above goals.

No meaningfulchange in performance

Seefaster-cpython/ideas#112 for motivation

https://bugs.python.org/issue45753

@markshannon
Copy link
MemberAuthor

Skipping NEWS as this is just a refactor. There is no change to behavior, API, or performance.

@markshannon
Copy link
MemberAuthor

The Windows failure appears to be a glitch.

@markshannon
Copy link
MemberAuthor

@pablogsal Could you take a look at the rearrangement of the code inRETURN_VALUE andYIELD_ instructions.
Does it seem reasonable to you?

@pablogsal
Copy link
Member

@pablogsal Could you take a look at the rearrangement of the code inRETURN_VALUE andYIELD_ instructions.
Does it seem reasonable to you?

I'm currently unavailable until this Friday. Can you wait until then?

@markshannon
Copy link
MemberAuthor

@pablogsal Could you take a look at the rearrangement of the code inRETURN_VALUE andYIELD_ instructions.
Does it seem reasonable to you?

I'm currently unavailable until this Friday. Can you wait until then?

No problem

Copy link
Member

@brandtbucherbrandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some comments while you wait for Pablo. Many are probably just for improving my own understanding of the changes here:

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@markshannonmarkshannon added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelNov 29, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@markshannon for commit88610c7 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelNov 29, 2021
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have a few questions and nits but I think I understand this well enough to approve once you've replied to those -- you can take them or leave them.

@markshannonmarkshannon merged commit49444fb intopython:mainDec 1, 2021
@markshannonmarkshannon deleted the interpreter-internal-tweaks branchSeptember 26, 2023 12:47
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gvanrossumgvanrossumgvanrossum left review comments

@brandtbucherbrandtbucherbrandtbucher requested changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@markshannon@pablogsal@bedevere-bot@gvanrossum@brandtbucher@the-knights-who-say-ni

[8]ページ先頭

©2009-2025 Movatter.jp