Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
bpo-45723: Add --with-pkg-config to configure (GH-29517)#29517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
e6a5f7e tod0e72b7CompareLet users require or ignore pkg-config. ``--with-pkg-config`` makespkg-config mandatory. ``--without-pkg-config`` disables use ofpkg-config. Disabling is also useful to check how configure behaveswithout pkg-config installed.Signed-off-by: Christian Heimes <christian@python.org>
d0e72b7 tof1bd071CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good. I think a note inBuild Changes inWhat's New would be nice.
Uh oh!
There was an error while loading.Please reload this page.
| if test -z "$PKG_CONFIG"; then | ||
| dnl invalidate stale config.cache values | ||
| AS_UNSET([PKG_CONFIG]) | ||
| AS_UNSET([ac_cv_path_ac_pt_PKG_CONFIG]) | ||
| AS_UNSET([ac_cv_prog_ac_ct_PKG_CONFIG]) | ||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
UnsettingPKG_CONFIG and friends ifPKG_CONFIG is not set? Is there a missing! in the test? Is this check needed at all; the config.cache guard is pretty strict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's un-declaring the variables when it's empty. This solves a corner case when going from./configure -C --without-pkg-config to./configure -C --with-pkg-config=yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe you are able to find a better way...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I see. No, this is fine. I can't think of a better way.
Is it worth it listing the packages we actually use |
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
The pkg-config m4 macro will do that for us. |
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Uh oh!
There was an error while loading.Please reload this page.
Let users require or ignore pkg-config.
--with-pkg-configmakespkg-config mandatory.
--without-pkg-configdisables use ofpkg-config. Disabling is also useful to check how configure behaves
without pkg-config installed.
Signed-off-by: Christian Heimeschristian@python.org
https://bugs.python.org/issue45723