Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-45723: Remove dead code for obsolete--with-dyld option#29500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedNov 9, 2021•
edited by miss-islington
Loading

Was commented out by Jack Jansen in 2001-08-15 by commit
b6e9cad:

"Ripped out Next/OpenStep support, which was broken anyway"

https://bugs.python.org/issue45723

Automerge-Triggered-By: GH:tiran

Was commented out by Jack Jansen in 2001-08-15 by commitb6e9cad:"Ripped out Next/OpenStep support, which was broken anyway"
Copy link
Member

@tirantiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

Copy link
Member

@tirantiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You need to regenerateconfigure, too.

erlend-aasland reacted with thumbs up emoji
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@erlend-aasland
Copy link
ContributorAuthor

You need to regenerate configure, too.

Hm, we could add aconfigure/configure.ac check to theCheck if generated files are up to date CI.

@tiran
Copy link
Member

You need to regenerate configure, too.

Hm, we could add aconfigure/configure.ac check to theCheck if generated files are up to date CI.

First I like to move my repo to python org and figure out hosting on ghcr.io.

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a success ✅ .

@miss-islingtonmiss-islington merged commit49171aa intopython:mainNov 9, 2021
@erlend-aaslanderlend-aasland deleted the ac-remove-dead-code branchNovember 9, 2021 21:06
thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull requestNov 9, 2021
thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull requestNov 9, 2021
thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull requestNov 9, 2021
thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull requestNov 9, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull requestDec 7, 2021
…GH-29500)Was commented out by Jack Jansen in 2001-08-15 by commitb6e9cad:"Ripped out Next/OpenStep support, which was broken anyway"Automerge-Triggered-By: GH:tiran
remykarem pushed a commit to remykarem/cpython that referenced this pull requestJan 30, 2022
…GH-29500)Was commented out by Jack Jansen in 2001-08-15 by commitb6e9cad:"Ripped out Next/OpenStep support, which was broken anyway"Automerge-Triggered-By: GH:tiran
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tirantirantiran approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@erlend-aasland@bedevere-bot@tiran@miss-islington@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp