Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-45723: Add macro for disabling/enabling CC warnings (GH-29466)#29466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tiran merged 8 commits intopython:mainfromerlend-aasland:ac-cc-flags
Nov 8, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedNov 8, 2021•
edited
Loading

  • AddPY_CHECK_CC_WARNING helper
  • Normalise variable name:ac_cv_[enable|disable]_[flag_name]_warning; for exampleac_cv_disable_unused_result_warning
  • UseAS_IF to check results and add flags

No new cache vars added, so there is no speedups; only simplified ac code.

Bonus: fixed a misspelling bug (seeac_cv_enable_enable_strict_prototypes_warning)

https://bugs.python.org/issue45723

@erlend-aasland
Copy link
ContributorAuthor

cc.@tiran

@erlend-aaslanderlend-aasland marked this pull request as ready for reviewNovember 8, 2021 10:47
- Use AS_VAR_IF() a couple of more times- Use CFLAGS iso. CC when overriding compiler flags
@tirantiran added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelNov 8, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@tiran for commit304f780 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelNov 8, 2021
@erlend-aasland
Copy link
ContributorAuthor

Do you want a NEWS item for this,@tiran?

Copy link
Member

@tirantiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks!

erlend-aasland reacted with hooray emoji
@erlend-aasland
Copy link
ContributorAuthor

Thanks for reviewing!

@tirantiran changed the titlebpo-45723: Add macro for disabling/enabling CC warningsbpo-45723: Add macro for disabling/enabling CC warnings (GH-29466)Nov 8, 2021
@tirantiran merged commit9bd0cf5 intopython:mainNov 8, 2021
@erlend-aaslanderlend-aasland deleted the ac-cc-flags branchNovember 8, 2021 17:59
remykarem pushed a commit to remykarem/cpython that referenced this pull requestDec 7, 2021
Co-authored-by: Christian Heimes <christian@python.org>
remykarem pushed a commit to remykarem/cpython that referenced this pull requestJan 30, 2022
Co-authored-by: Christian Heimes <christian@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tirantirantiran approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@erlend-aasland@bedevere-bot@tiran@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp