Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-45723: Detect missing pkg-config (GH-29442)#29442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tiran merged 4 commits intopython:mainfromtiran:bpo-45723-pkgconf
Nov 7, 2021

Conversation

tiran
Copy link
Member

@tirantiran commentedNov 6, 2021•
edited by bedevere-bot
Loading

@tirantiran changed the titleDetect missing pkg-configbpo-45723: Detect missing pkg-configNov 6, 2021
Copy link
Member

@ned-deilyned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Where is AC_PATH_TOOL being picked up from? The current PR doesn't work for me.

@ned-deily
Copy link
Member

[...]config.status: creating pyconfig.hcreating Modules/Setup.localcreating Makefilepkg-config is missing. Some dependencies may not be detected correctly.If you want a release build with all stable optimizations active (PGO, etc),please run ./configure --enable-optimizations$ pkg-configMust specify package names on the command line$ which pkg-config/usr/bin/pkg-config

This is on a reasonably vanilla Debian system. Also the same on macOS with pkg-config installed from MacPorts.

@tiran
Copy link
MemberAuthor

tiran commentedNov 6, 2021•
edited
Loading

Strange ... could you please paste the output ofgrep PKG_CONFIG config.log ?

My system (Fedora 34):

$ grep PKG_CONFIG config.log ac_cv_env_PKG_CONFIG_LIBDIR_set=ac_cv_env_PKG_CONFIG_LIBDIR_value=ac_cv_env_PKG_CONFIG_PATH_set=ac_cv_env_PKG_CONFIG_PATH_value=ac_cv_env_PKG_CONFIG_set=ac_cv_env_PKG_CONFIG_value=ac_cv_path_ac_pt_PKG_CONFIG=/usr/bin/pkg-configac_cv_prog_ac_ct_PKG_CONFIG=/usr/bin/pkg-configPKG_CONFIG='/usr/bin/pkg-config'PKG_CONFIG_LIBDIR=''PKG_CONFIG_PATH=''

@tiran
Copy link
MemberAuthor

Where is AC_PATH_TOOL being picked up from? The current PR doesn't work for me.

AC_PATH_TOOL is provided byautoconf/programs.m4.

@tiran
Copy link
MemberAuthor

D'oh, I puttest -n to test the output message and forgot to replace it withtest -z.

ned-deily reacted with laugh emoji

@tirantiran marked this pull request as ready for reviewNovember 6, 2021 19:01
@tirantiran changed the titlebpo-45723: Detect missing pkg-configbpo-45723: Detect missing pkg-config (GH-29442)Nov 7, 2021
@tirantiran merged commitbe3cd5c intopython:mainNov 7, 2021
@tirantiran deleted the bpo-45723-pkgconf branchNovember 7, 2021 10:18
remykarem pushed a commit to remykarem/cpython that referenced this pull requestDec 7, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull requestJan 30, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pablogsalpablogsalpablogsal left review comments

@ned-deilyned-deilyned-deily approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@tiran@ned-deily@pablogsal@the-knights-who-say-ni@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp