Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-45723: Prepare support for autoconf 2.71 (GH-29441)#29441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tiran merged 1 commit intopython:mainfromtiran:bpo-45723-prep271
Nov 8, 2021

Conversation

tiran
Copy link
Member

@tirantiran commentedNov 6, 2021•
edited by bedevere-bot
Loading

AC_PROG_EGREP should be checked explicitly.

AC_CONFIG_HEADER ->AC_CONFIG_HEADERS

AC_USE_SYSTEM_EXTENSIONS must be defined before first use ofAC_LINK
orAC_COMPILE macros.

STDC_HEADERS andAC_HEADER_TIME are obsolete.

Signed-off-by: Christian Heimeschristian@python.org

https://bugs.python.org/issue45723

erlend-aasland reacted with heart emoji
@tirantiran marked this pull request as ready for reviewNovember 7, 2021 09:34
@tirantiran added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelNov 7, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@tiran for commit 2b2a10ebcb4216c271248e2191c64f29a7a68912 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelNov 7, 2021
@tiran
Copy link
MemberAuthor

All changes are based on the output of 2.71's autoupdate tool.

Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I took a quick look and left some comments.

@tiran
Copy link
MemberAuthor

autoconf 2.71 has deprecated the macro:

configure.ac:660: warning: The macro `AC_PROG_CC_C99' is obsolete.configure.ac:660: You should run autoupdate.
erlend-aasland reacted with laugh emoji

@erlend-aasland
Copy link
Contributor

autoconf 2.71 has deprecated the macro:

configure.ac:660: warning: The macro `AC_PROG_CC_C99' is obsolete.configure.ac:660: You should run autoupdate.

Oh, well 😆

@tiran
Copy link
MemberAuthor

In autoconf 2.71,AC_PROG_CC_C99 is an alias forAC_PROG_CC

@erlend-aasland
Copy link
Contributor

erlend-aasland commentedNov 8, 2021•
edited
Loading

In autoconf 2.71,AC_PROG_CC_C99 is an alias forAC_PROG_CC

It seems that we can useAC_PROG_CC and checkac_cv_prog_cc_c99:

Otherwise, if ac_cv_prog_cc_c99 is set to any value other than ‘no’(including the empty string), then CC can compile code as standardC 1999, and this mode has been enabled

@erlend-aasland
Copy link
Contributor

BTW, we need to make sure we setCFLAGS before callingAC_PROG_CC, so we don't accidentally default to-g -O2.

@tiran
Copy link
MemberAuthor

In autoconf 2.71,AC_PROG_CC_C99 is an alias forAC_PROG_CC

It seems that we can useAC_PROG_CC and checkac_cv_prog_cc_c99:

Otherwise, if ac_cv_prog_cc_c99 is set to any value other than ‘no’(including the empty string), then CC can compile code as standardC 1999, and this mode has been enabled

autoconf 2.71 no longer defines the variableac_cv_prog_cc_c99. autoconf 2.69 only defines it for AC_PROG_CC_STDC.

erlend-aasland reacted with thumbs up emoji

Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but I think one NEWS entry is enough ;)

``AC_PROG_EGREP`` should be checked explicitly.``AC_CONFIG_HEADER`` -> ``AC_CONFIG_HEADERS````AC_USE_SYSTEM_EXTENSIONS`` must be defined before first use of ``AC_LINK``or ``AC_COMPILE`` macros.``STDC_HEADERS`` and ``AC_HEADER_TIME`` are obsolete.Signed-off-by: Christian Heimes <christian@python.org>
@tiran
Copy link
MemberAuthor

LGTM, but I think one NEWS entry is enough ;)

Oops :)

I have removed the second entry and rebased the PR.

erlend-aasland reacted with hooray emoji

@tirantiran changed the titlebpo-45723: Prepare support for autoconf 2.71bpo-45723: Prepare support for autoconf 2.71 (GH-29441)Nov 8, 2021
@tirantiran merged commitcbab997 intopython:mainNov 8, 2021
@tirantiran deleted the bpo-45723-prep271 branchNovember 8, 2021 18:31
remykarem pushed a commit to remykarem/cpython that referenced this pull requestDec 7, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@tiran@bedevere-bot@erlend-aasland@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp