Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-87799: Improve the textual representation of IPv4-mapped IPv6 addresses#29345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
opavlyuk commentedNov 9, 2021
@maxmouchet,@ykvch guys, please take a look on this PR when you get a chance. |
maxmouchet commentedNov 9, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks for tackling this! This looks good to me. Maybe the |
opavlyuk commentedNov 10, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks! Lets discuss it.
In addition,RFC 4007 Section 4 says that
That is all I managed to find regarding the subject. Please, let me know what you think about it. |
opavlyuk commentedNov 10, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Noticed, thatipaddress.IPv6Address.exploded behavior differs from expected after the patch: I'm in progress fixing that. |
This PR is stale because it has been open for 30 days with no activity. |
MaxwellDupre left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ran 203 tests in 0.198s
OK
== Tests result: SUCCESS ==
And I get:>>> addr.exploded '0000:0000:0000:0000:0000:ffff:8.8.4.4'
Looks good to me.
ghost commentedMay 3, 2022 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
…essesRepresent IPv4-mapped IPv6 address as x:x:x:x:x:x:d.d.d.d,where the 'x's are the hexadecimal valuesof the six high-order 16-bit pieces of the address,and the 'd's are the decimal valuesof the four low-order 8-bit pieces of the address(standard IPv4 representation).
arhadthedev commentedApr 13, 2023
@opavlyuk Could you sign the new CLA by clicking |
opavlyuk commentedApr 13, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@arhadthedev Thanks for letting me know! I initially used the wrong SSH key for the commits, but I've fixed it and the CLA is now marked as signed. |
arhadthedev commentedApr 13, 2023
For now, we need to wait.
|
opavlyuk commentedApr 13, 2023
@arhadthedev Thanks for clearing things up! Then I'll watch out for the 3.12b1 release and return to the PR once all obstacles are cleared. |
opavlyuk commentedMay 16, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@arhadthedev it appears a month has passed since the last update to the PR, during which time we haven't received further feedback. Also, I noticed that version 3.12.0a7 was released just yesterday. |
opavlyuk commentedJun 1, 2023
@encukou as you may recall, we had a conversation during PyCon SK 2022 where you kindly offered your guidance and support. I'm now writing to kindly ask if you could take a look at this PR. I would greatly appreciate your review, or if you could suggest someone who might be the right person for this task. Thank you for your time and consideration! |
opavlyuk commentedJul 6, 2023
@asvetlov could you please review this PR at your earliest convenience? |
…6 addresses (pythonGH-29345)Represent IPv4-mapped IPv6 address as x:x:x:x:x:x:d.d.d.d,where the 'x's are the hexadecimal valuesof the six high-order 16-bit pieces of the address,and the 'd's are the decimal valuesof the four low-order 8-bit pieces of the address(standard IPv4 representation).---------(cherry picked from commitf22bf8e)Co-authored-by: opavliuk <40970635+opavlyuk@users.noreply.github.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
…6 addresses (pythonGH-29345)Represent IPv4-mapped IPv6 address as x:x:x:x:x:x:d.d.d.d,where the 'x's are the hexadecimal valuesof the six high-order 16-bit pieces of the address,and the 'd's are the decimal valuesof the four low-order 8-bit pieces of the address(standard IPv4 representation).---------(cherry picked from commitf22bf8e)Co-authored-by: opavliuk <40970635+opavlyuk@users.noreply.github.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
GH-135078 is a backport of this pull request to the3.9 branch. |
…6 addresses (pythonGH-29345)Represent IPv4-mapped IPv6 address as x:x:x:x:x:x:d.d.d.d,where the 'x's are the hexadecimal valuesof the six high-order 16-bit pieces of the address,and the 'd's are the decimal valuesof the four low-order 8-bit pieces of the address(standard IPv4 representation).---------(cherry picked from commitf22bf8e)Co-authored-by: opavliuk <40970635+opavlyuk@users.noreply.github.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
GH-135079 is a backport of this pull request to the3.10 branch. |
GH-135080 is a backport of this pull request to the3.11 branch. |
…6 addresses (pythonGH-29345)Represent IPv4-mapped IPv6 address as x:x:x:x:x:x:d.d.d.d,where the 'x's are the hexadecimal valuesof the six high-order 16-bit pieces of the address,and the 'd's are the decimal valuesof the four low-order 8-bit pieces of the address(standard IPv4 representation).---------(cherry picked from commitf22bf8e)Co-authored-by: opavliuk <40970635+opavlyuk@users.noreply.github.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
GH-135081 is a backport of this pull request to the3.12 branch. |
…v6 addresses (GH-29345) (GH-135080)Represent IPv4-mapped IPv6 address as x:x:x:x:x:x:d.d.d.d,where the 'x's are the hexadecimal valuesof the six high-order 16-bit pieces of the address,and the 'd's are the decimal valuesof the four low-order 8-bit pieces of the address(standard IPv4 representation).(cherry picked from commitf22bf8e)Co-authored-by: opavliuk <40970635+opavlyuk@users.noreply.github.com>Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
…v6 addresses (GH-29345) (GH-135081)Represent IPv4-mapped IPv6 address as x:x:x:x:x:x:d.d.d.d,where the 'x's are the hexadecimal valuesof the six high-order 16-bit pieces of the address,and the 'd's are the decimal valuesof the four low-order 8-bit pieces of the address(standard IPv4 representation).(cherry picked from commitf22bf8e)Co-authored-by: opavliuk <40970635+opavlyuk@users.noreply.github.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
…6 addresses (GH-29345) (GH-135078)Represent IPv4-mapped IPv6 address as x:x:x:x:x:x:d.d.d.d,where the 'x's are the hexadecimal valuesof the six high-order 16-bit pieces of the address,and the 'd's are the decimal valuesof the four low-order 8-bit pieces of the address(standard IPv4 representation).(cherry picked from commitf22bf8e)Co-authored-by: opavliuk <40970635+opavlyuk@users.noreply.github.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
…v6 addresses (GH-29345) (GH-135079)Represent IPv4-mapped IPv6 address as x:x:x:x:x:x:d.d.d.d,where the 'x's are the hexadecimal valuesof the six high-order 16-bit pieces of the address,and the 'd's are the decimal valuesof the four low-order 8-bit pieces of the address(standard IPv4 representation).(cherry picked from commitf22bf8e)Co-authored-by: opavliuk <40970635+opavlyuk@users.noreply.github.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
https://bugs.python.org/issue43633