NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

[3.10] bpo-45624: make test_graphlib not depend on the iteration order of sets (GH-29233)#29293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ambv merged 1 commit intopython:3.10frommiss-islington:backport-7401694-3.10

Oct 28, 2021

Merged

[3.10] bpo-45624: make test_graphlib not depend on the iteration order of sets (GH-29233)#29293

ambv merged 1 commit intopython:3.10frommiss-islington:backport-7401694-3.10

Oct 28, 2021

Conversation

Copy link

Contributor

miss-islington commentedOct 28, 2021•
edited by bedevere-bot
Loading

the current test depended on integer sets being iterated on in a certain
fixed order. That order is different on PyPy (insertion based) and could
change in CPython in the future in theory. Make the test robust against
a different iteration order by sorting.
(cherry picked from commit7401694)

Co-authored-by: Carl Friedrich Bolz-Tereickcfbolz@gmx.de

https://bugs.python.org/issue45624

bpo-45624: make test_graphlib not depend on the iteration order of se…

285ee84

…ts (pythonGH-29233)the current test depended on integer sets being iterated on in a certainfixed order. That order is different on PyPy (insertion based) and couldchange in CPython in the future in theory. Make the test robust againsta different iteration order by sorting.(cherry picked from commit7401694)Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>