Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-45634: Don't combine error checks when addingsqlite3 int constants#29251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
corona10 merged 3 commits intopython:mainfromerlend-aasland:sqlite-fix-add-ints
Oct 31, 2021

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedOct 27, 2021•
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commentedOct 27, 2021•
edited
Loading

FYI, 3.9 does this right. Actually, it's worse :) But backporting to 3.9 wouldnot be straight-forward. The module init code has changed substantially between 3.9 and 3.10, so I'd prefer to leave 3.9 as it is.

@erlend-aasland
Copy link
ContributorAuthor

Note to self: updateGH-28463 after merge.

@corona10corona10 merged commit39b4d59 intopython:mainOct 31, 2021
@miss-islington
Copy link
Contributor

Thanks@erlend-aasland for the PR, and@corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry@erlend-aasland and@corona10, I had trouble checking out the3.10 backport branch.
Please backport usingcherry_picker on command line.
cherry_picker 39b4d5938ce781af41f8c9da72dee46095a78642 3.10

@erlend-aaslanderlend-aasland deleted the sqlite-fix-add-ints branchOctober 31, 2021 10:15
@erlend-aasland
Copy link
ContributorAuthor

Thanks,@corona10. I'll fix the backport.

erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull requestOct 31, 2021
…t constants (pythonGH-29251).(cherry picked from commit39b4d59)Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

GH-29343 is a backport of this pull request to the3.10 branch.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@corona10corona10corona10 approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

@ambvambvAwaiting requested review from ambv

+1 more reviewer

@gareth-reesgareth-reesgareth-rees left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@corona10corona10

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@erlend-aasland@miss-islington@bedevere-bot@gareth-rees@corona10@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp