Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-45618: Fix documentation build by pinning Docutils version#29230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ned-deily merged 2 commits intopython:mainfromm-aciek:docs-pin-docutils
Oct 27, 2021

Conversation

@m-aciek
Copy link
Contributor

@m-aciekm-aciek commentedOct 26, 2021•
edited by bedevere-bot
Loading

Since the release of Docutils 0.18 today building Python documentation fails.

In CPython repository we have Sphinx pinned to 3.2.1, which has too loose requirement for Docutils version in install_requires – docutils>=0.12.

Example of failing build:https://github.com/python/python-docs-pl/runs/4009459257.

The pin can be removed after bumping Sphinx to at least 3.5.4, which introduced upper limit for docutils version.

sphinx-doc/sphinx@9263eea

https://bugs.python.org/issue45618

@erlend-aasland
Copy link
Contributor

cc.@pablogsal

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Copy link
Member

@ned-deilyned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This should be OK as at least a temporary measure. I would like@JulienPalard as the documentation release expert to review the situation for a permanent solution. Other things will need to be updated one way or another.

erlend-aasland and m-aciek reacted with thumbs up emoji
@miss-islington
Copy link
Contributor

Thanks@m-aciek for the PR, and@ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 27, 2021
…7.1 (pythonGH-29230)Co-authored-by: Maciej Olko <maciej.olko@yougov.com>Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>(cherry picked from commitbcee6aa)Co-authored-by: m-aciek <m-aciek@users.noreply.github.com>
@miss-islington
Copy link
Contributor

Sorry,@m-aciek and@ned-deily, I could not cleanly backport this to3.9 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker bcee6aa31550cfecdc3acecbd0e4447bb0051887 3.9

@bedevere-bot
Copy link

GH-29240 is a backport of this pull request to the3.10 branch.

ned-deily pushed a commit to ned-deily/cpython that referenced this pull requestOct 27, 2021
…7.1 (pythonGH-29230)Co-authored-by: Maciej Olko <maciej.olko@yougov.com>Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

GH-29241 is a backport of this pull request to the3.9 branch.

ned-deily pushed a commit that referenced this pull requestOct 27, 2021
…7.1 (GH-29230) (GH-29240)Co-authored-by: Maciej Olko <maciej.olko@yougov.com>Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>(cherry picked from commitbcee6aa)
@JulienPalard
Copy link
Member

Thanks@m-aciek and@ned-deily for acting fast on this! The docutils release also broke pospell we use python-docs-fr side, I should have suspected it would broke Sphinx too, but I did not.

erlend-aasland reacted with thumbs up emoji

ned-deily added a commit that referenced this pull requestOct 27, 2021
…to 0.17.1 (GH-29230) (GH-29241)Co-authored-by: Maciej Olko <maciej.olko@yougov.com>Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@erlend-aasland
Copy link
Contributor

3.8 is not EOL yet, so I guess we have to backport to 3.8 as well,@ambv?

ned-deily added a commit to ned-deily/cpython that referenced this pull requestOct 27, 2021
…to 0.17.1 (pythonGH-29230) (pythonGH-29241)Co-authored-by: Maciej Olko <maciej.olko@yougov.com>Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@ned-deily
Copy link
Member

Yes, thanks, I've just submitted a 3.8 PR. Also, 3.7 and 3.6 are affected as well, since we build documentation for security-fix branches. But the backport is a little more complicated for them because the changes that introduced the use ofrequirements.txt in the DocMakefile were never backported to them. I should have done that before, we should do it now. If anyone gets to it first, yay.

m-aciek reacted with thumbs up emoji

@m-aciekm-aciek deleted the docs-pin-docutils branchOctober 27, 2021 20:16
ambv pushed a commit that referenced this pull requestOct 28, 2021
…to 0.17.1 (GH-29230) (GH-29241) (GH-29245)Co-authored-by: Maciej Olko <maciej.olko@yougov.com>Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@ned-deilyned-deilyned-deily approved these changes

@pablogsalpablogsalAwaiting requested review from pablogsal

@JulienPalardJulienPalardAwaiting requested review from JulienPalard

Assignees

@ned-deilyned-deily

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@m-aciek@erlend-aasland@miss-islington@bedevere-bot@JulienPalard@ned-deily@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp