Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-45613: Setsqlite3.threadsafety dynamically#29227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pablogsal merged 16 commits intopython:mainfromerlend-aasland:sqlite-threadsafety
Nov 3, 2021

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedOct 26, 2021•
edited
Loading

Use the compile-time selected default SQLite threaded mode to set the
DB-API 2.0 attribute 'threadsafety' during sqlite3 module initialisation.

SQLite to DB-API mappings:

  • SQLITE_THREADSAFE=0 => threadsafety=0 (single-thread mode)
  • SQLITE_THREADSAFE=1 => threadsafety=3 (fully threadsafe)
  • SQLITE_THREADSAFE=2 => threadsafety=1 (threadsafe at module level)

https://bugs.python.org/issue45613

Erlend E. Aasland added2 commitsOctober 26, 2021 14:26
Use the compile-time selected default SQLite threaded mode to set theDB-API 2.0 attribute 'threadsafety'Mappings:  - SQLITE_THREADSAFE=0 => threadsafety=0  - SQLITE_THREADSAFE=1 => threadsafety=3  - SQLITE_THREADSAFE=2 => threadsafety=1
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commentedOct 26, 2021•
edited
Loading

On hold till#29129 is merged. Will rebase and update docs before marking this as ready for review.

@erlend-aaslanderlend-aasland marked this pull request as draftOctober 28, 2021 07:12
@erlend-aaslanderlend-aasland marked this pull request as ready for reviewOctober 28, 2021 20:46
@erlend-aaslanderlend-aasland added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelOct 29, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@erlend-aasland for commit396abd4 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelOct 29, 2021
@erlend-aasland
Copy link
ContributorAuthor

Testing with buildbots to verify that this approach works across different SQLite versions/configurations. I've verified locally that it works with SQLite 3.7.15 (oldest supported), 3.36.0, and current 3.37.0 (dev).

@erlend-aaslanderlend-aasland added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelNov 2, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@erlend-aasland for commit686d70f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelNov 2, 2021
Copy link
Member

@malemburgmalemburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think the patch is good to go as-is, without the additional changes you mentioned in the comments. Thanks, Erlend.

erlend-aasland reacted with hooray emoji
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commentedNov 3, 2021•
edited
Loading

I think the patch is good to go as-is, without the additional changes you mentioned in the comments. Thanks, Erlend.

Thanks! There is one change I'd like to make before merging, though: add aversionchanged annotation to thethreadsafety attribute doc.

Copy link
Member

@pablogsalpablogsal left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@malemburg do you have anything else you would like here to be addressed?

Edit: ah, I just saw that you approved before. I am landing this then

erlend-aasland reacted with hooray emoji
@pablogsalpablogsal merged commitc273986 intopython:mainNov 3, 2021
@erlend-aaslanderlend-aasland deleted the sqlite-threadsafety branchNovember 3, 2021 21:01
@erlend-aasland
Copy link
ContributorAuthor

Thanks, Marc-Andre & Pablo 🙏🏻

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@malemburgmalemburgmalemburg approved these changes

@pablogsalpablogsalpablogsal approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland@bedevere-bot@malemburg@pablogsal@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp