Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
bpo-45600: Enhanced / clarified the docs for os.environ and os.environb#29204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Doc/library/os.rst Outdated
| A:term:`mapping` objectrepresenting the string environment. For example, | ||
| ``environ['HOME']`` is the pathname of your home directory (on some platforms), | ||
| and is equivalent to ``getenv("HOME")`` in C. | ||
| A:term:`mapping` objectof key and value strings that represent the process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This isn't valid English. You want to say "of string keys and values", or less tersely "where keys and values are strings" which I think reads better.
Doc/library/os.rst Outdated
| Bytes version of:data:`environ`: a:term:`mapping` objectof key and value | ||
| byte strings representing the process environment.:data:`environ` and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Similarly, here you can say "where both keys and values are :class:bytes objects" (we avoid saying "byte strings" now, there is only a few cases of this left in the entire documentation).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I like "keys and values are strings", updated.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
miss-islington commentedOct 29, 2021
miss-islington commentedOct 29, 2021
…nb (pythonGH-29204)Co-authored-by: Łukasz Langa <lukasz@langa.pl>(cherry picked from commitb17cfd1)Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
…nb (pythonGH-29204)Co-authored-by: Łukasz Langa <lukasz@langa.pl>(cherry picked from commitb17cfd1)Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
bedevere-bot commentedOct 29, 2021
GH-29321 is a backport of this pull request to the3.9 branch. |
bedevere-bot commentedOct 29, 2021
GH-29322 is a backport of this pull request to the3.10 branch. |
akulakov commentedOct 30, 2021
@ambv thanks for reviewing! |
Uh oh!
There was an error while loading.Please reload this page.
https://bugs.python.org/issue45600
Co-authored by Eryk Sun