Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-45583: Correct datamodel.rst documentation of int()#29182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 1 commit intopython:mainfromArthur-Milchior:main
Oct 28, 2021

Conversation

@Arthur-Milchior
Copy link
Contributor

@Arthur-MilchiorArthur-Milchior commentedOct 23, 2021•
edited by bedevere-bot
Loading

bpo-45583: Correct datamodel.rst documentation of int()

It should be noted that this part of the documentation is redundant with
function.rst's documentation of int. This one was correctly updated with Python 3.8

https://bugs.python.org/issue45583

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed thePSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find abugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Arthur-Milchior

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please followthe steps outlined in the CPython devguide to rectify this issue.

You cancheck yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-botbedevere-bot added the docsDocumentation in the Doc dir labelOct 23, 2021
@Arthur-Milchior
Copy link
ContributorAuthor

I confirm I just signed the CLA.
Since the CLA ask for the bugs.python.org username I just created the account ArthurMilchior and indicated that my github name is Arthur-Milchior.
So normallyhttps://check-python-cla.herokuapp.com/ should be able to confirm I signed it (even if it's surprising it asks for github username which was not provided in the CLA in the first place)

@Arthur-Milchior
Copy link
ContributorAuthor

I think it would also need to be backported to 3.8, since it was when the change was introduced. I see only 3.9 and 3.10 labels added

@serhiy-storchakaserhiy-storchaka changed the titleCorrect datamodel.rst documentation of int()bpo-45583: Correct datamodel.rst documentation of int()Oct 23, 2021
Copy link
Member

@mdickinsonmdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is fine - it's a net improvement on what's already there. But at a nitpick level, it still reads as somewhat ambiguous to me: in the qualifier

if :meth:__int__ and :meth:__index__ are not defined

it's not immediately clear whether it refers to the situation whereneither of these is defined, or to the situation where they're notboth defined. You could possibly tighten it up as:

if neither :meth:__int__ nor :meth:__index__ is defined

Approving, since this is good to go as-is - the above is just a suggestion.

@mdickinson
Copy link
Member

@Arthur-Milchior

I think it would also need to be backported to 3.8

3.8 is in security-fix-only mode at this point, so we wouldn't normally backport docfixes to 3.8.

should I still be listed as the commit author while you are the one who wrote the actual sentence

Unless@serhiy-storchaka objects, I think that's fine.@serhiy-storchaka has one or two other commits to his name. :-)

It should be noted that this part of the documentation is redundant withfunction.rst's documentation of int. This one was correctly updated with Python 3.8
@Arthur-Milchior
Copy link
ContributorAuthor

Thanks for the explanation. I admit that I'm just a Python user and didn't check the rules for what is ported or not to previous version.
Do you have any idea how much time I should wait after signing the CLA for it to be shown as signed?

@miss-islington
Copy link
Contributor

Thanks@Arthur-Milchior for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 28, 2021
It should be noted that this part of the documentation is redundant withfunction.rst's documentation of int. This one was correctly updated with Python 3.8.(cherry picked from commitd9c1868)Co-authored-by: Arthur Milchior <arthur@milchior.fr>
@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelOct 28, 2021
@bedevere-bot
Copy link

GH-29285 is a backport of this pull request to the3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 28, 2021
It should be noted that this part of the documentation is redundant withfunction.rst's documentation of int. This one was correctly updated with Python 3.8.(cherry picked from commitd9c1868)Co-authored-by: Arthur Milchior <arthur@milchior.fr>
@bedevere-bot
Copy link

GH-29286 is a backport of this pull request to the3.9 branch.

@bedevere-bot
Copy link

GH-29287 is a backport of this pull request to the3.8 branch.

ambv pushed a commit that referenced this pull requestOct 28, 2021
)It should be noted that this part of the documentation is redundant withfunction.rst's documentation of int. This one was correctly updated with Python 3.8.(cherry picked from commitd9c1868)Co-authored-by: Arthur Milchior <arthur@milchior.fr>
ambv pushed a commit that referenced this pull requestOct 28, 2021
)It should be noted that this part of the documentation is redundant withfunction.rst's documentation of int. This one was correctly updated with Python 3.8.(cherry picked from commitd9c1868)Co-authored-by: Arthur Milchior <arthur@milchior.fr>
ambv pushed a commit that referenced this pull requestOct 28, 2021
)It should be noted that this part of the documentation is redundant withfunction.rst's documentation of int. This one was correctly updated with Python 3.8.(cherry picked from commitd9c1868)Co-authored-by: Arthur Milchior <arthur@milchior.fr>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

+1 more reviewer

@mdickinsonmdickinsonmdickinson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Arthur-Milchior@the-knights-who-say-ni@mdickinson@miss-islington@bedevere-bot@serhiy-storchaka@ambv
[8]ページ先頭
©2009-2025 Movatter.jp