Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[3.9] bpo-45520: Backport __getstate__, __setstate__ methods fordataclasses from 3.10 into 3.9 (GH-25786)#29147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
sobolevn wants to merge2 commits intopython:3.9fromsobolevn:issue-45520

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commentedOct 22, 2021•
edited
Loading

@sobolevnsobolevn changed the titleBackport__getstate__,__setstate__ methods from 3.10 into 3.9[3.9] bpo-45520: Backport __getstate__, __setstate__ methods from 3.10 into 3.9 (GH-25786)Oct 22, 2021
@sobolevnsobolevn reopened thisOct 22, 2021
@sobolevn
Copy link
MemberAuthor

sobolevn commentedOct 22, 2021•
edited
Loading

I'll toggle this PR once again after all other tests pass, because Azure seems to be broken for some unrelated reason.

@sobolevn
Copy link
MemberAuthor

It now passes!

I've also createdhttps://bugs.python.org/issue45566 to sync thepickle protocols thing with more recent versions.

miss-islington pushed a commit that referenced this pull requestOct 24, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 24, 2021
…GH-29150)Refspython#29147Automerge-Triggered-By: GH:ericvsmith(cherry picked from commit07236d5)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull requestOct 24, 2021
Refs#29147Automerge-Triggered-By: GH:ericvsmith(cherry picked from commit07236d5)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@sobolevn
Copy link
MemberAuthor

Friendly ping@ericvsmith 🙂

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelNov 29, 2021
@sobolevn
Copy link
MemberAuthor

@github-actionsgithub-actionsbot removed the staleStale PR or inactive for long period of time. labelNov 30, 2021
@merwok
Copy link
Member

Please mention dataclasses in the PR title

sobolevn reacted with thumbs up emoji

@sobolevnsobolevn changed the title[3.9] bpo-45520: Backport __getstate__, __setstate__ methods from 3.10 into 3.9 (GH-25786)[3.9] bpo-45520: Backport __getstate__, __setstate__ methods fordataclasses from 3.10 into 3.9 (GH-25786)Jan 2, 2022
@Fidget-Spinner
Copy link
Member

@sobolevn sorry for the really long delay (I dropped the ball on this notification for a month). Unfortunately I have to admit I'm clueless at pickle so I can't review this.

@sobolevn
Copy link
MemberAuthor

sobolevn commentedJan 12, 2022•
edited
Loading

@Fidget-Spinner no worries, thanks for your work!

This is a backport of a bugfix from3.10 to3.9
For some reason it was not done in#25786

CC@JelleZijlstra as the original reviewer 🙂

@JelleZijlstra
Copy link
Member

Since dataclasses only gained native slot support in 3.10, it doesn't seem important to apply this fix to 3.9. (It affects people who set__slots__ manually, but if you do that it doesn't seem too bad to also manually provide pickle support.) Also, unconditionally setting these methods is risky; it may overwrite a user-provided method.

I'll leave the decision to@ericvsmith though.

Copy link
Contributor

@MaxwellDupreMaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ran 175 tests in 1.202s
OK
Looks reasonable.

@ambv
Copy link
Contributor

We're releasing the last bugfix release of 3.9 today and this PR's been stale for a while. Sadly it's awontfix now.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ericvsmithericvsmithAwaiting requested review from ericvsmithericvsmith is a code owner

1 more reviewer

@MaxwellDupreMaxwellDupreMaxwellDupre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@sobolevn@merwok@Fidget-Spinner@JelleZijlstra@ambv@MaxwellDupre@the-knights-who-say-ni@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp