Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-45557: Fix underscore_numbers in pprint.pprint().#29129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ericvsmith merged 2 commits intopython:mainfromericvsmith:issue45557
Oct 21, 2021

Conversation

@ericvsmith
Copy link
Member

@ericvsmithericvsmith commentedOct 21, 2021•
edited by bedevere-bot
Loading

pprint.pprint() always passesunderscore_numbers=False to pformat(), it should useunderscore_numbers=underscore_numbers.

https://bugs.python.org/issue45557

@ericvsmith
Copy link
MemberAuthor

There's no test for this, because in general the pprint module doesn't testpprint.pprint(). I'll open an issue for that.

@ericvsmith
Copy link
MemberAuthor

I createdhttps://bugs.python.org/issue45559 for testingpprint.pprint().

@ericvsmithericvsmith merged commit087f089 intopython:mainOct 21, 2021
@miss-islington
Copy link
Contributor

Thanks@ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 21, 2021
(cherry picked from commit087f089)Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
@bedevere-bot
Copy link

GH-29133 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelOct 21, 2021
@ericvsmithericvsmith deleted the issue45557 branchOctober 21, 2021 20:43
miss-islington added a commit that referenced this pull requestOct 21, 2021
(cherry picked from commit087f089)Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@zwarezwarezware approved these changes

+1 more reviewer

@jpvincent1980jpvincent1980jpvincent1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ericvsmithericvsmith

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ericvsmith@miss-islington@bedevere-bot@zware@jpvincent1980@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp