Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-45516: add protocol description to the Traversable documentation#29039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaraco merged 4 commits intopython:mainfromFFY00:bpo-45516-traversable
Oct 18, 2021

Conversation

@FFY00
Copy link
Member

@FFY00FFY00 commentedOct 18, 2021•
edited by bedevere-bot
Loading

Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Copy link
MemberAuthor

We can backport this, right?

@jaraco
Copy link
Member

We can backport this, right?

Not exactly. Docs aren't synced between CPython and importlib_resources, so including this additional detail is going to require adding a lot more unsynchronized reference material to importlib_resources. It's probably not worth it. Let's just maintain the reference material here.

FFY00and others added2 commitsOctober 18, 2021 21:06
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@FFY00
Copy link
MemberAuthor

Sounds good 😊

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@jaracojaraco merged commit4d03de3 intopython:mainOct 18, 2021
@bedevere-bot
Copy link

@jaraco: Please replace# withGH- in the commit message next time. Thanks!

@jaraco
Copy link
Member

We can backport this, right?

Not exactly. Docs aren't synced between CPython and importlib_resources, so including this additional detail is going to require adding a lot more unsynchronized reference material to importlib_resources. It's probably not worth it. Let's just maintain the reference material here.

Wait. Did you mean backport to importlib_resources or backport to Python 3.10/3.9? If the latter, then probably yes.

@FFY00
Copy link
MemberAuthor

FFY00 commentedOct 31, 2021•
edited
Loading

The later, I wasn't sure since you maintain a cpython branch.

jaraco reacted with thumbs up emoji

@miss-islington
Copy link
Contributor

Thanks@FFY00 for the PR, and@jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks@FFY00 for the PR, and@jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 31, 2021
…ythonGH-29039)* bpo-45516: add protocol description to the Traversable documentationSigned-off-by: Filipe Laíns <lains@riseup.net>* Update Doc/library/importlib.rstCo-authored-by: Jason R. Coombs <jaraco@jaraco.com>* Update Lib/importlib/abc.py* Update Doc/library/importlib.rstCo-authored-by: Jason R. Coombs <jaraco@jaraco.com>Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>(cherry picked from commit4d03de3)Co-authored-by: Filipe Laíns <filipe.lains@gmail.com>
@bedevere-bot
Copy link

GH-29348 is a backport of this pull request to the3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 31, 2021
…ythonGH-29039)* bpo-45516: add protocol description to the Traversable documentationSigned-off-by: Filipe Laíns <lains@riseup.net>* Update Doc/library/importlib.rstCo-authored-by: Jason R. Coombs <jaraco@jaraco.com>* Update Lib/importlib/abc.py* Update Doc/library/importlib.rstCo-authored-by: Jason R. Coombs <jaraco@jaraco.com>Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>(cherry picked from commit4d03de3)Co-authored-by: Filipe Laíns <filipe.lains@gmail.com>
@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelOct 31, 2021
@bedevere-bot
Copy link

GH-29349 is a backport of this pull request to the3.10 branch.

miss-islington added a commit that referenced this pull requestOct 31, 2021
…H-29039)*bpo-45516: add protocol description to the Traversable documentationSigned-off-by: Filipe Laíns <lains@riseup.net>* Update Doc/library/importlib.rstCo-authored-by: Jason R. Coombs <jaraco@jaraco.com>* Update Lib/importlib/abc.py* Update Doc/library/importlib.rstCo-authored-by: Jason R. Coombs <jaraco@jaraco.com>Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>(cherry picked from commit4d03de3)Co-authored-by: Filipe Laíns <filipe.lains@gmail.com>
miss-islington added a commit that referenced this pull requestOct 31, 2021
…H-29039)*bpo-45516: add protocol description to the Traversable documentationSigned-off-by: Filipe Laíns <lains@riseup.net>* Update Doc/library/importlib.rstCo-authored-by: Jason R. Coombs <jaraco@jaraco.com>* Update Lib/importlib/abc.py* Update Doc/library/importlib.rstCo-authored-by: Jason R. Coombs <jaraco@jaraco.com>Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>(cherry picked from commit4d03de3)Co-authored-by: Filipe Laíns <filipe.lains@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jaracojaracojaraco approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@FFY00@jaraco@bedevere-bot@miss-islington@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp