Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix docs source link for importlib.metadata#29025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
miss-islington merged 1 commit intopython:mainfromflying-sheep:patch-1
Oct 30, 2021

Conversation

@flying-sheep
Copy link
Contributor

@flying-sheepflying-sheep commentedOct 18, 2021•
edited by miss-islington
Loading

The link broke for Python 3.10 since importlib.metadata was made from a module into a package

I think this is trivial enough to not need a bpo issue.

Automerge-Triggered-By: GH:jaraco

@bedevere-botbedevere-bot added the docsDocumentation in the Doc dir labelOct 18, 2021
@FFY00
Copy link
Member

Ugh, docs are a bit of a pain to keep in sync 😅

@FFY00
Copy link
Member

@jaraco, remember to change the target branch to main and add the backport label 😁

flying-sheep reacted with eyes emoji

@jaraco
Copy link
Member

We'll want to apply this change to the cpython branch of importlib_metadata also. Otherwise, it might get overwritten during the next update from there.

@jaracojaraco assignedjaraco and unassignedjaracoOct 23, 2021
@FFY00
Copy link
Member

The importlib_metadata does not contain this link, it is part of the CPython only header.

@jaraco
Copy link
Member

I applied the change atpython/importlib_metadata@90083722648.

@jaraco
Copy link
Member

@jaraco, remember to change the target branch to main and add the backport label 😁

Good catch. I not only had to change the target branch, but I had to cherry-pick and force-push the change againstmain (because CPython doesn't use the SCM to maintain ancestry of changes).

@jaracojaraco added the needs backport to 3.10only security fixes labelOct 30, 2021
@miss-islington
Copy link
Contributor

@flying-sheep: Status check is done, and it's a success ✅ .

@miss-islingtonmiss-islington merged commitaae18a1 intopython:mainOct 30, 2021
@miss-islington
Copy link
Contributor

Thanks@flying-sheep for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

flying-sheep reacted with heart emoji

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 30, 2021
The link broke for Python 3.10 since importlib.metadata was made from a module into a packageI think this is trivial enough to not need a bpo issue.Automerge-Triggered-By: GH:jaraco(cherry picked from commitaae18a1)Co-authored-by: Philipp A <flying-sheep@web.de>
@bedevere-bot
Copy link

GH-29330 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelOct 30, 2021
miss-islington added a commit that referenced this pull requestOct 30, 2021
The link broke for Python 3.10 since importlib.metadata was made from a module into a packageI think this is trivial enough to not need a bpo issue.Automerge-Triggered-By: GH:jaraco(cherry picked from commitaae18a1)Co-authored-by: Philipp A <flying-sheep@web.de>
@flying-sheepflying-sheep deleted the patch-1 branchOctober 30, 2021 15:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jaracojaracojaraco approved these changes

@FFY00FFY00FFY00 approved these changes

@1st11st1Awaiting requested review from 1st1

@abalkinabalkinAwaiting requested review from abalkin

@asvetlovasvetlovAwaiting requested review from asvetlov

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag

@brettcannonbrettcannonAwaiting requested review from brettcannon

@cjw296cjw296Awaiting requested review from cjw296

@encukouencukouAwaiting requested review from encukou

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrently

@ericvsmithericvsmithAwaiting requested review from ericvsmith

@ethanfurmanethanfurmanAwaiting requested review from ethanfurman

@ezio-melottiezio-melottiAwaiting requested review from ezio-melotti

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

@gpsheadgpsheadAwaiting requested review from gpshead

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

@isidenticalisidenticalAwaiting requested review from isidentical

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaou

@markshannonmarkshannonAwaiting requested review from markshannon

@methanemethaneAwaiting requested review from methane

@ncoghlanncoghlanAwaiting requested review from ncoghlan

@pablogsalpablogsalAwaiting requested review from pablogsal

@pgansslepganssleAwaiting requested review from pganssle

@rhettingerrhettingerAwaiting requested review from rhettinger

@terryjreedyterryjreedyAwaiting requested review from terryjreedy

@tirantiranAwaiting requested review from tiran

@vsajipvsajipAwaiting requested review from vsajip

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@flying-sheep@FFY00@jaraco@miss-islington@bedevere-bot@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp