Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
bpo-45502: Fix test_shelve#29003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Run test_shelve with all underlying dbm implementations and pickle protocols.Also make test_shelve discoverable.
bedevere-bot commentedOct 19, 2021
ambv commentedOct 20, 2021
Gentoo buildbot failures unrelated perBPO-45436 (now fixed). Re-runninghttps://buildbot.python.org/all/#/builders/721/builds/50 to see if the segfault is reproducible. Looks related since it's a failure in test_shelve which is the subject of this PR. |
serhiy-storchaka commentedOct 20, 2021
Crashed again at same place (in |
serhiy-storchaka commentedOct 20, 2021
@pablogsal could you please run this test separately? |
serhiy-storchaka commentedOct 20, 2021
I see that tests on this buildbot are ran with option |
pablogsal commentedOct 20, 2021
This ishttps://bugs.python.org/issue45289 no? This should be deactivated on the buildbot: |
serhiy-storchaka commentedOct 20, 2021
ned-deily commentedOct 20, 2021
FWIW, I haven't looked much yet into these crashes but I haven't run into them myself yet. I suspect it's an interaction with the Homebrew-installed gdbm which macOS does not ship with. We also don't include gdbm in the python.org macOS binaries. |
ambv commentedOct 22, 2021
Sincepython/buildmaster-config#293 is landed, this can be merged as well. |
miss-islington commentedOct 22, 2021
Thanks@serhiy-storchaka for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
miss-islington commentedOct 22, 2021
Sorry,@serhiy-storchaka and@ambv, I could not cleanly backport this to |
miss-islington commentedOct 22, 2021
Sorry@serhiy-storchaka and@ambv, I had trouble checking out the |
Run test_shelve with all underlying dbm implementations and pickle protocols.Also make test_shelve discoverable..(cherry picked from commitb781cc3)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
bedevere-bot commentedOct 29, 2021
GH-29305 is a backport of this pull request to the3.10 branch. |
bedevere-bot commentedOct 29, 2021
|
Uh oh!
There was an error while loading.Please reload this page.
Run test_shelve with all underlying dbm implementations and pickle protocols.
Also make test_shelve discoverable.
https://bugs.python.org/issue45502