Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-45502: Fix test_shelve#29003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 1 commit intopython:mainfromserhiy-storchaka:test_shelve
Oct 22, 2021
Merged

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedOct 17, 2021
edited by bedevere-bot
Loading

Run test_shelve with all underlying dbm implementations and pickle protocols.
Also make test_shelve discoverable.

https://bugs.python.org/issue45502

Run test_shelve with all underlying dbm implementations and pickle protocols.Also make test_shelve discoverable.
@ambvambv added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelOct 19, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@ambv for commita5436d9 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelOct 19, 2021
@ambv
Copy link
Contributor

Gentoo buildbot failures unrelated perBPO-45436 (now fixed).

Re-runninghttps://buildbot.python.org/all/#/builders/721/builds/50 to see if the segfault is reproducible. Looks related since it's a failure in test_shelve which is the subject of this PR.

@serhiy-storchaka
Copy link
MemberAuthor

Crashed again at same place (in_dbm.dbm.keys()). It is either a bug in thedbm.ndbm module or memory corruption in one of previous tests.

@serhiy-storchaka
Copy link
MemberAuthor

@pablogsal could you please run this test separately?

./python -m test -vuall test_shelve./python -m test -vuall test_shelve -m TestProto0File_ndbmShelve./python -m test -vuall test_shelve -m test.test_shelve.TestProto0File_ndbmShelve.test_read

@serhiy-storchaka
Copy link
MemberAuthor

I see that tests on this buildbot are ran with option-x test_dbm test_dbm_ndbm. Seems thedbm.ndbm module is broken on this buildbot.

@pablogsal
Copy link
Member

I see that tests on this buildbot are ran with option-x test_dbm test_dbm_ndbm. Seems thedbm.ndbm module is broken on this buildbot.

This ishttps://bugs.python.org/issue45289 no? This should be deactivated on the buildbot:

https://github.com/python/buildmaster-config/blob/ec3ba6f4866ccc42d98137c82aba48632bfc03c4/master/custom/factories.py#L406

@serhiy-storchaka
Copy link
MemberAuthor

@ned-deily
Copy link
Member

FWIW, I haven't looked much yet into these crashes but I haven't run into them myself yet. I suspect it's an interaction with the Homebrew-installed gdbm which macOS does not ship with. We also don't include gdbm in the python.org macOS binaries.

@ambv
Copy link
Contributor

Sincepython/buildmaster-config#293 is landed, this can be merged as well.

@ambvambv merged commitb781cc3 intopython:mainOct 22, 2021
@miss-islington
Copy link
Contributor

Thanks@serhiy-storchaka for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@serhiy-storchaka and@ambv, I could not cleanly backport this to3.10 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker b781cc3bfce7c052728b06aad9f1a467cced289d 3.10

@miss-islington
Copy link
Contributor

Sorry@serhiy-storchaka and@ambv, I had trouble checking out the3.9 backport branch.
Please backport usingcherry_picker on command line.
cherry_picker b781cc3bfce7c052728b06aad9f1a467cced289d 3.9

@serhiy-storchakaserhiy-storchaka deleted the test_shelve branchOctober 29, 2021 08:54
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestOct 29, 2021
Run test_shelve with all underlying dbm implementations and pickle protocols.Also make test_shelve discoverable..(cherry picked from commitb781cc3)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-29305 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelOct 29, 2021
serhiy-storchaka added a commit that referenced this pull requestOct 29, 2021
Run test_shelve with all underlying dbm implementations and pickle protocols.Also make test_shelve discoverable.(cherry picked from commitb781cc3)
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestOct 29, 2021
)Run test_shelve with all underlying dbm implementations and pickle protocols.Also make test_shelve discoverable.(cherry picked from commitb781cc3).(cherry picked from commit6b86702)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull requestOct 29, 2021
Run test_shelve with all underlying dbm implementations and pickle protocols.Also make test_shelve discoverable.(cherry picked from commitb781cc3).(cherry picked from commit6b86702)
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Arch Linux Asan 3.9 has failed when building commita043706.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/579/builds/244) and take a look at the build logs.
  4. Check if the failure is related to this commit (a043706) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/579/builds/244

Summary of the results of the build (if available):

Click to see traceback logs
Traceback (most recent call last):  File"/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Lib/multiprocessing/resource_tracker.py", line201, inmain    cache[rtype].remove(name)KeyError:'/psm_bbb15bda'

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@ambvambv

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@serhiy-storchaka@bedevere-bot@ambv@pablogsal@ned-deily@miss-islington@hugovk@the-knights-who-say-ni

[8]ページ先頭

©2009-2025 Movatter.jp