Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

tiny speedup in shutil fast copy on Windows#28898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
landfillbaby wants to merge2 commits intopython:mainfromlandfillbaby:patch-1
Closed

tiny speedup in shutil fast copy on Windows#28898

landfillbaby wants to merge2 commits intopython:mainfromlandfillbaby:patch-1

Conversation

@landfillbaby
Copy link
Contributor

can't see why the final write was doing a 2nd lookup of fdst.write

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed thePSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find abugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@landfillbaby

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please followthe steps outlined in the CPython devguide to rectify this issue.

You cancheck yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@landfillbaby
Copy link
ContributorAuthor

landfillbaby commentedOct 12, 2021
edited
Loading

do i really need to sign the CLA for a single byte of changes? can't i just say it's WTFPL or something
edit: ok fine i did it

@landfillbaby
Copy link
ContributorAuthor

landfillbaby commentedOct 13, 2021
edited
Loading

yeah looking at the original PRs that added this stuff,#7160 and#7681, it seems like without the with statements there's no proper memoryview deallocation, and a CopyFile[Ex]W implementation was reverted due to those functions copyingtoo much with no flag to disable it (metadata, forks, etc)

@landfillbaby
Copy link
ContributorAuthor

i also just noticed it attempts a 2nd read after the case where output is less than the buffer size. unless that's intended i'm adding abreak

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelNov 14, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting reviewstaleStale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@landfillbaby@the-knights-who-say-ni@bedevere-bot

[8]ページ先頭

©2009-2026 Movatter.jp