Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-45325: Add a new 'p' parameter to Py_BuildValue to convert an integer into a Python bool#28634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pablogsal merged 1 commit intopython:mainfrompablogsal:bpo-45325
Feb 18, 2025

Conversation

pablogsal
Copy link
Member

@pablogsalpablogsal commentedSep 29, 2021•
edited by bedevere-bot
Loading

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but it would be interested to see if/how this feature would be useful in the existing code:https://bugs.python.org/issue45325#msg402900

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

And if you don't make the requested changes, you will be poked with soft cushions!

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelNov 1, 2021
@vstinner
Copy link
Member

@pablogsal: Do you plan to update your PR?

@pablogsal
Copy link
MemberAuthor

@pablogsal: Do you plan to update your PR?

Yep, I just time :)

@github-actionsgithub-actionsbot removed the staleStale PR or inactive for long period of time. labelNov 10, 2021
@pablogsal
Copy link
MemberAuthor

@brandtbucher can you review again?

@pablogsal
Copy link
MemberAuthor

I have rebased and updated the PR.

@pablogsalpablogsal merged commit51d4bf1 intopython:mainFeb 18, 2025
45 of 46 checks passed
@pablogsalpablogsal deleted the bpo-45325 branchFebruary 18, 2025 17:14
@serhiy-storchaka
Copy link
Member

This PR was merged, but the discussion on#89488 was not finished. I have concerns that this is a dangerous feature.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner approved these changes

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments

@serhiy-storchakaserhiy-storchakaserhiy-storchaka left review comments

@ezio-melottiezio-melottiezio-melotti left review comments

@brandtbucherbrandtbucherbrandtbucher approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8 participants
@pablogsal@bedevere-bot@vstinner@serhiy-storchaka@JelleZijlstra@ezio-melotti@brandtbucher@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp