NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

gh-89562: Remove hostflags from PySSLContext#28602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gpshead merged 1 commit intopython:mainfromramikg:remove-hostflags-from-pysslcontext-struct

Apr 18, 2025

Merged

gh-89562: Remove hostflags from PySSLContext#28602

gpshead merged 1 commit intopython:mainfromramikg:remove-hostflags-from-pysslcontext-struct

Apr 18, 2025

Conversation

Copy link

Contributor

ramikg commentedSep 28, 2021•
edited by bedevere-appbot
Loading

ThePySSLContext struct inModules/_ssl.c mentions that "OpenSSL has no API to get hostflags from X509_VERIFY_PARAM* struct. We have to maintain our own copy".
Since OpenSSL 1.1.0i added the functionX509_VERIFY_PARAM_get_hostflags, this statement is no longer true.
Because Python 3.10 requires OpenSSL 1.1.1 (PEP 644), we no longer have to maintain a copy of the host flags.

This PR removes thehostflags member from thePySSLContext struct.

https://bugs.python.org/issue45399

Issue:Remove hostflags from PySSLContext #89562

the-knights-who-say-ni added the CLA signed label

Sep 28, 2021

bedevere-bot added the awaiting review label

Sep 28, 2021

ramikg changed the title~~Remove hostflags from PySSLContext~~bpo-43669: Remove hostflags from PySSLContext

Oct 7, 2021

tiran requested changes

Oct 7, 2021

View reviewed changes

Copy link

Member

tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

bpo-43669 is closed. This PR needs a new ticket.

bedevere-bot added awaiting changes and removed awaiting review labels

Oct 7, 2021

Copy link

bedevere-bot commentedOct 7, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link

ContributorAuthor

ramikg commentedOct 7, 2021

bpo-43669 is closed. This PR needs a new ticket.

Is it possible to submit this PR without a bpo? (on the count of it being trivial)

Copy link

Member

tiran commentedOct 7, 2021

bpo-43669 is closed. This PR needs a new ticket.
Is it possible to submit this PR without a bpo? (on the count of it being trivial)

No, this is not a trivial change. Python requires a ticket for every change that has even a remote chance of affecting a single user. By definition, C and OpenSSL are not trivial, too.