Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-45209: fixUserWarning: resource_tracker in test_multiprocessing#28377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 4 commits intopython:mainfromsobolevn:issue-45209
Sep 21, 2021

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedSep 15, 2021•
edited
Loading

@vstinner
Copy link
Member

cc@pitrou

@pitroupitrou changed the titlebpo-45209: removesUserWarning: resource_tracker in `test_multiproc…bpo-45209: fixUserWarning: resource_tracker in test_multiprocessingSep 16, 2021
@vstinner
Copy link
Member

Windows build error on Azure Pipelines is tracked by:https://bugs.python.org/issue45220

@sobolevn
Copy link
MemberAuthor

Rebased, CI now passes.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.@pitrou: Would you mind to double check this multiprocessing test fix?

I'm kind of unhappy that you have to prepend "/". SharedMemory._prepend_leading_slash does a magic dance (add/remove "/" prefix) with SharedMemory(name) constructor parameter and in SharedMemory.name property. But I don't think that it's worth it to add something just for this very specific test. We can always revisit the code later if we start to have issue on some corner cases.

@sobolevn
Copy link
MemberAuthor

I'm kind of unhappy that you have to prepend "/". SharedMemory._prepend_leading_slash does a magic dance (add/remove "/" prefix) with SharedMemory(name) constructor parameter and in SharedMemory.name property

Yes, me too. I've tried several other things likesmm.name (was not producing the correct result by raisingKeyError). After several attempts this was the simplest solution. And since we only run this part on posix, it should work correctly.

Thanks,@vstinner and@pitrou

@ambv
Copy link
Contributor

Since the slash hack is tests-only, let's have it. We can fix the fix later if we find a way to do so.

sobolevn reacted with hooray emoji

@ambvambv merged commitf604cf1 intopython:mainSep 21, 2021
@vstinnervstinner added the needs backport to 3.10only security fixes labelSep 21, 2021
@miss-islington
Copy link
Contributor

Thanks@sobolevn for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 21, 2021
pythonGH-28377)(cherry picked from commitf604cf1)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

GH-28499 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelSep 21, 2021
@vstinnervstinner added the needs backport to 3.9only security fixes labelSep 21, 2021
@miss-islington
Copy link
Contributor

Thanks@sobolevn for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-28500 is a backport of this pull request to the3.9 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.9only security fixes labelSep 21, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 21, 2021
pythonGH-28377)(cherry picked from commitf604cf1)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull requestSep 21, 2021
GH-28377)(cherry picked from commitf604cf1)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
vstinner pushed a commit that referenced this pull requestSep 21, 2021
GH-28377) (GH-28500)(cherry picked from commitf604cf1)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pitroupitroupitrou left review comments

@vstinnervstinnervstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@sobolevn@vstinner@ambv@miss-islington@bedevere-bot@pitrou@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp