Before, this was only enforced on the Windows platform, where multiple calls would result in errors. But logically it is the correct behavior, and it allows simplifying the code as well.

This also includes a minor change to correctly useplatform.system() == "Windows" rather than.startswith("Windows").

Note that this requires the fix in PRGH-28328 to work properly on Linux.

Also, note that this has no effect on the position of the completion window while scrolling the editor window, which isn't updated anyways as far as I can tell.

Issue:IDLE: Simplify autocomplete window configuration #96910

IDLE: make the auto-complete window's winnconfig handler only trigger…

68f9010

… onceBefore, this was only enforced on the Windowsplatform, where multiple calls would result inerrors. But logically it is the correct behavior,and it allows simplifying the code as well.Signed-off-by: Tal Einat <532281+taleinat@users.noreply.github.com>

taleinat requested a review fromterryjreedy

September 14, 2021 15:23

the-knights-who-say-ni added the CLA signed label

Sep 14, 2021

bedevere-bot added the awaiting core review label

Sep 14, 2021

Copy link

github-actionsbot commentedOct 16, 2021

This PR is stale because it has been open for 30 days with no activity.

github-actionsbot added the staleStale PR or inactive for long period of time. label

Oct 16, 2021

Copy link

Member

terryjreedy commentedJan 24, 2022•
edited by bedevere-bot
Loading

PR#28328 forbpo-45193 was closed and a simpler fix applied to 3.11 and 3.10, with a fix for 3.9 pending. This should work for 3.11 and .10. I am thinking of backporting a simplified version to 3.9 and not worry that it is not perfect.

Closing and opening to see current results.

In msg401802 ofbpo-45193, I said "I would rather make a more extensive change than to patch a badly written function for at least the fourth time. I will open an issue for [this] PR and explain later." If I cannot soon remember what I meant, I should apply this after more test and review.

terryjreedy closed this

Jan 24, 2022

terryjreedy reopened this

Jan 24, 2022

taleinat mentioned this pull request

May 18, 2022

IDLE Show completions pop-up not working on Ubuntu Linux#89356

Closed

ezio-melotti removed the CLA signed label

Jul 13, 2022

github-actionsbot removed the staleStale PR or inactive for long period of time. label

Aug 12, 2022

terryjreedy changed the title~~IDLE: make the auto-complete window's winnconfig handler only trigger once~~gh-96910: IDLE - make autocomplete winnconfig handler only trigger once

Sep 18, 2022

terryjreedy self-assigned this

Sep 18, 2022