Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
bpo-38291: Update 3.10 WhatsNew with typing.{io|re} DeprecationWarning#27872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@srittau can I trouble you for a review please? It concerns your work :). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
| @@ -1401,6 +1401,13 @@ subclasses with the :func:`runtime_checkable` decorator | |||
| if they want runtime protocols. | |||
| (Contributed by Yurii Karabas in :issue:`38908`) | |||
| Importing from the ``typing.io`` and ``typing.re`` submodules will now emit | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is worth to add it in the "Deprecated" section below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Initially I thought no because What's new in 3.8 should have ithttps://docs.python.org/3/whatsnew/3.8.html#deprecated, but surprisingly it doesn't. So yep we should add it as a proper reminder this time.
Thanks@Fidget-Spinner for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
bedevere-bot commentedAug 23, 2021
GH-27907 is a backport of this pull request to the3.10 branch. |
pythonGH-27872)(cherry picked from commit1a995b0)Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
https://bugs.python.org/issue38291