NotificationsYou must be signed in to change notification settings
Fork34k
Star71.3k

bpo-44951: Allow setting EPOLLEXCLUSIVE on selectors.EpollSelector#27819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

dgilman wants to merge1 commit intopython:main

base:main

Choose a base branch

fromdgilman:epollexclusive

Open

bpo-44951: Allow setting EPOLLEXCLUSIVE on selectors.EpollSelector#27819

dgilman wants to merge1 commit intopython:mainfromdgilman:epollexclusive

+66 −5

Conversation

Copy link

dgilman commentedAug 19, 2021•
edited by encukou
Loading

See:

https://bugs.python.org/issue44951 (GH-89114)
https://bugs.python.org/issue35517 (GH-79698)
#11193

https://bugs.python.org/issue44951

Copy link

the-knights-who-say-ni commentedAug 19, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed thePSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@dgilman

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please followthe steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You cancheck yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

the-knights-who-say-ni added the CLA not signed label

Aug 19, 2021

bedevere-bot added the awaiting review label

Aug 19, 2021

dgilman force-pushed theepollexclusive branch from8601851 to7e54752Compare

August 19, 2021 03:22

dgilman changed the title~~issue44951: Allow setting EPOLLEXCLUSIVE on selectors.EpollSelector~~bpo-44951: Allow setting EPOLLEXCLUSIVE on selectors.EpollSelector

Aug 19, 2021

the-knights-who-say-ni added CLA signed and removed CLA not signed labels

Aug 19, 2021

ambv reviewed

Sep 7, 2021

View reviewed changes

Lib/selectors.py Outdated

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Since this is in a method literally calledregister, I'd name the new argument simplyflags.

Lib/selectors.py Outdated

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

So farselectors haven't had this but looking atasyncio,ssl,socket,threading, andmultiprocessing code, we usually either use properties forboth getting and setting a value, or we useboth aget_* and aset_* method.

Since we already haveget_key andget_map inselectors.py, and there are no public fields nor properties here, I'd change theexclusive getter to an explicitget_exclusive() method.

Copy link

Author

dgilman commentedSep 11, 2021

Thanks for the feedback - I think it is best to get a decision made on whether this approach is the way to go (modify the Epoll class) or if it should be an entirely new EpollExclusiveSelector class with no API changes.