Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-30969: Fix docs about the comparison in absence of __contains__#2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
csabella merged 4 commits intopython:masterfromztane:patch-1
May 30, 2019

Conversation

@ztane
Copy link
Contributor

@ztaneztane commentedJul 19, 2017
edited by bedevere-bot
Loading

The documentation doesn't match the implementation, which clearly doesx is y or x == y to check ifx is the elementy from a container. Both the__iter__ and the index-iteration method test the elements usingis first. While the document says thatx is x means thatx == x should be true, it is not true for example in the case ofnan:

>>> x == xFalse>>> x is xTrue```The following demonstrates the behaviour that is against the documented behaviour:```>>> class Foo:...     def __iter__(self):...         return iter([x])... >>> x in Foo()True>>> any(x == i for i in Foo())False>>> class Bar:...     def __getitem__(self):...         return [x].__getitem__(self)... >>> class Bar:...     def __getitem__(self, i):...         return [x].__getitem__(i)... >>> x in BarTraceback (most recent call last):  File "<stdin>", line 1, in <module>TypeError: argument of type 'type' is not iterable>>> x in Bar()True>>> any(x == i for i in Bar())False```<!-- issue-number: [bpo-30969](https://bugs.python.org/issue30969) -->https://bugs.python.org/issue30969<!-- /issue-number -->

Both the `__iter__` and the index-iteration method test the `is` first. While the document says that `x is x` means that `x == x` should be true, it is not true for example in the case of `nan`. ```>>> x = float('nan') >>> x == xFalse>>> x is xTrue>>> class Foo:...     def __iter__(self):...         return iter([x])... >>> x in Foo()True>>> any(x == i for i in Foo())False>>> class Bar:...     def __getitem__(self):...         return [x].__getitem__(self)... >>> class Bar:...     def __getitem__(self, i):...         return [x].__getitem__(i)... >>> x in BarTraceback (most recent call last):  File "<stdin>", line 1, in <module>TypeError: argument of type 'type' is not iterable>>> x in Bar()True>>> any(x == i for i in Bar())False```
@mention-bot
Copy link

@ztane, thanks for your PR! By analyzing the history of the files in this pull request, we identified@birkenfeld,@vadmium and@benjaminp to be potential reviewers.

@serhiy-storchakaserhiy-storchaka added the docsDocumentation in the Doc dir labelDec 8, 2018
:meth:`__iter__`, ``x in y`` is ``True`` if some value ``z`` with ``x == z`` is
produced while iterating over ``y``. If an exception is raised during the
iteration, it is as if:keyword:`in` raised that exception.
:meth:`__iter__`, ``x in y`` is ``True`` if some value ``z``, for which the
Copy link
Member

@tirkarthitirkarthiJan 8, 2019
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@ztane trailing space in the three lines are causing CI failure. Removing them will fix the issue. Thanks for the patch.

Doc git:(pr_2761) python3 tools/rstlint.py -i tools -i ./venv -i README.rst[1] reference/expressions.rst:1446: trailing whitespace[1] reference/expressions.rst:1447: trailing whitespace[1] reference/expressions.rst:1448: trailing whitespace3 problems with severity 1 found.

@csabella
Copy link
Contributor

@ztane, please apply the suggestions from@tirkarthi to fix the CI failures. Thanks!

@miss-islington
Copy link
Contributor

Thanks@ztane for the PR, and@csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 30, 2019
…ythonGH-2761)(cherry picked from commit2f5b9dc)Co-authored-by: Antti Haapala <antti@haapala.name>
@bedevere-bot
Copy link

GH-13684 is a backport of this pull request to the3.7 branch.

miss-islington added a commit that referenced this pull requestMay 30, 2019
…H-2761)(cherry picked from commit2f5b9dc)Co-authored-by: Antti Haapala <antti@haapala.name>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tirkarthitirkarthitirkarthi left review comments

@rhettingerrhettingerrhettinger approved these changes

@csabellacsabellacsabella approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@ztane@mention-bot@csabella@miss-islington@bedevere-bot@rhettinger@tirkarthi@brettcannon@serhiy-storchaka@the-knights-who-say-ni

[8]ページ先頭

©2009-2025 Movatter.jp