NotificationsYou must be signed in to change notification settings
Fork34k
Star71.3k

bpo-44688: Remove ASCII limitation from`sqlite3` collation names#27395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

encukou merged 7 commits intopython:mainfromerlend-aasland:sqlite-remove-collation-ascii-limitation

Jul 29, 2021

Merged

bpo-44688: Remove ASCII limitation from`sqlite3` collation names#27395

encukou merged 7 commits intopython:mainfromerlend-aasland:sqlite-remove-collation-ascii-limitation

Jul 29, 2021

Conversation

Copy link

Contributor

erlend-aasland commentedJul 27, 2021•
edited by bedevere-bot
Loading

https://bugs.python.org/issue44688

Erlend E. Aasland added2 commits

July 27, 2021 23:33

bpo-44688: sqlite3 now accepts UTF8 collation names

3f9e3c7

Docs

13e17db

erlend-aasland requested a review fromberkerpeksag as acode owner

July 27, 2021 21:46

bedevere-bot added the awaiting review label

Jul 27, 2021

the-knights-who-say-ni added the CLA signed label

Jul 27, 2021

erlend-aasland requested a review fromencukou

July 27, 2021 21:46

Copy link

ContributorAuthor

erlend-aasland commentedJul 27, 2021•
edited
Loading

cc.@encukou: ref. discussion in#27156 (comment)

erlend-aasland mentioned this pull request

Jul 27, 2021

bpo-42064: Migrate tosqlite3_create_collation_v2#27156

Merged

encukou reviewed

Jul 28, 2021

View reviewed changes

Copy link

Member

encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice! Just a terminology issue: the Python interface doesn't deal with UTF-8 (bytes); in py3 it always took a Unicode string.

For completeness, could you mention the pre-3.11 limitation in the documentation? (I think it's OK to only have it in the 3.11+ docs, but IMO it should be there for people porting code from 3.11 to previous versions.)

Misc/NEWS.d/next/Library/2021-07-20-23-28-26.bpo-44688.buFgz3.rst OutdatedShow resolvedHide resolved

Lib/sqlite3/test/hooks.py OutdatedShow resolvedHide resolved

Doc/whatsnew/3.11.rst OutdatedShow resolvedHide resolved

Erlend Egeberg Aaslandand others added3 commits

July 28, 2021 10:22

Address review: adjust NEWS entry wording

ea65d23

Co-authored-by: Petr Viktorin <encukou@gmail.com>

Address review: revert test method renaming

f34461d

Co-authored-by: Petr Viktorin <encukou@gmail.com>

Address review: Improve What's New wording

1f0e959

Co-authored-by: Petr Viktorin <encukou@gmail.com>

Copy link

ContributorAuthor

erlend-aasland commentedJul 28, 2021

Nice! Just a terminology issue: the Python interface doesn't deal with UTF-8 (bytes); in py3 it always took a Unicode string.

Thanks for the heads up and the suggested improvements.

For completeness, could you mention the pre-3.11 limitation in the documentation? (I think it's OK to only have it in the 3.11+ docs, but IMO it should be there for people porting code from 3.11 to previous versions.)

Of course.

Address review: mention previous limitation in the docs

74f7108

erlend-aasland requested a review fromencukou

July 28, 2021 08:35

Remove trailing whitespace

dfa343f

Copy link

ContributorAuthor

erlend-aasland commentedJul 28, 2021

The address sanitiser test timed out during one of the multiprocessing tests. Looks unrelated.

https://github.com/python/cpython/pull/27395/checks?check_run_id=3181419480

Copy link

Member

encukou commentedJul 28, 2021

I see@pablogsal added the address sanitizer in#26640.
Is it normally flaky?

encukou closed this

Jul 28, 2021

encukou reopened this

Jul 28, 2021

Copy link

Member

pablogsal commentedJul 28, 2021

I see@pablogsal added the address sanitizer in#26640.
Is it normally flaky?

No regarding detection of problems but a small subset of times it times out. What error are you experiencing?

Copy link

ContributorAuthor

erlend-aasland commentedJul 28, 2021

Is it normally flaky?
No regarding detection of problems but a small subset of times it times out. What error are you experiencing?

test_get intest_multiprocessing_fork timed out in both test runs on the last CI run. I can't recall seeing that particular failure before. See attached log.

log.txt