Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.10] bpo-42073: allow classmethod to wrap other classmethod-like descriptors (GH-27115)#27162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 1 commit intopython:3.10frommiss-islington:backport-b83861f-3.10
Jul 15, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islingtonmiss-islington commentedJul 15, 2021
edited by bedevere-bot
Loading

Patch by Erik Welch.

bpo-19072 (GH-8405) allowsclassmethod to wrap other descriptors, but this does
not work when the wrapped descriptor mimics classmethod. The current PR fixes
this.

In Python 3.8 and before, one could create a callable descriptor such that this
works as expected (see Lib/test/test_decorators.py for examples):

classA:@myclassmethoddeff1(cls):returncls@classmethod@myclassmethoddeff2(cls):returncls

In Python 3.8 and before,A.f2() returnA. Currently in Python 3.9, it
returnstype(A). This PR makeA.f2() returnA again.

As ofGH-8405, classmethod callsobj.__get__(type) ifobj has__get__.
This allows one to chain@classmethod and@property together. When
using classmethod-like descriptors, it's the second argument to__get__--the
owner or the type--that is important, but this argument is currently missing.
Since it is None, the "owner" argument is assumed to be the type of the first
argument, which, in this case, is wrong (we wantA, nottype(A)).

This PR updates classmethod to callobj.__get__(type, type) ifobj has
__get__.

Co-authored-by: Erik Welcherik.n.welch@gmail.com
(cherry picked from commitb83861f)

Co-authored-by: Łukasz Langalukasz@langa.pl

https://bugs.python.org/issue42073

…rs (pythonGH-27115)Patch by Erik Welch.bpo-19072 (pythonGH-8405) allows `classmethod` to wrap other descriptors, but this doesnot work when the wrapped descriptor mimics classmethod.  The current PR fixesthis.In Python 3.8 and before, one could create a callable descriptor such that thisworks as expected (see Lib/test/test_decorators.py for examples):```pythonclass A:    @myclassmethod    def f1(cls):        return cls@classmethod    @myclassmethod    def f2(cls):        return cls```In Python 3.8 and before, `A.f2()` return `A`. Currently in Python 3.9, itreturns `type(A)`.  This PR make `A.f2()` return `A` again.As ofpythonGH-8405, classmethod calls `obj.__get__(type)` if `obj` has `__get__`.This allows one to chain `@classmethod` and `@property` together.  Whenusing classmethod-like descriptors, it's the second argument to `__get__`--theowner or the type--that is important, but this argument is currently missing.Since it is None, the "owner" argument is assumed to be the type of the firstargument, which, in this case, is wrong (we want `A`, not `type(A)`).This PR updates classmethod to call `obj.__get__(type, type)` if `obj` has`__get__`.Co-authored-by: Erik Welch <erik.n.welch@gmail.com>(cherry picked from commitb83861f)Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@miss-islington
Copy link
ContributorAuthor

@ambv: Status check is done, and it's a success ✅ .

@ambvambv merged commit2ce8af3 intopython:3.10Jul 15, 2021
@miss-islingtonmiss-islington deleted the backport-b83861f-3.10 branchJuly 15, 2021 13:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@miss-islington@ambv@the-knights-who-say-ni@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp