Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-44647: Fix test_httpservers failing on Unicode characters in os.environ on Windows#27161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 7 commits intopython:mainfromambv:debug-azure-pipelines-accept
Jul 15, 2021

Conversation

ambv
Copy link
Contributor

@ambvambv commentedJul 15, 2021•
edited
Loading

GH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all ofos.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test.

Check the issue for more details, and the comments in this PR for hunting the root cause down. This was first encountered when working onGH-27115.

https://bugs.python.org/issue44647

@ambv
Copy link
ContributorAuthor

Disablingdb.read_windows_registry() inmimetypes.py didn't change anything here. Another attempt will be to change the result type from text/plain to text/html.

@ambv
Copy link
ContributorAuthor

Looks like this is an Azure Pipelines problem. All the passing PRs that don't trip overtest_httpservers are running on:

Current image version: '20210628.1'

While all the PRs that fail intest_httpservers are running on:

Current image version: '20210711.1'

@ambvambvforce-pushed thedebug-azure-pipelines-accept branch fromdb40e30 tofbbb3c3CompareJuly 15, 2021 14:45
@ambv
Copy link
ContributorAuthor

OK, back to square one. There are newer PRs on image 20210711.1 that pass. Knowing my luck, the failures are because my name is Łukasz.

@ambv
Copy link
ContributorAuthor

Knowing my luck, the failures are because my name is Łukasz.

THIS WAS SUPPOSED TO BE A JOKE

Screenshot 2021-07-15 at 19 35 45

I filedhttps://bugs.python.org/issue44647

IvanLauLinTiong and hugovk reacted with thumbs up emojisco1, graingert, anentropic, RenGeng, hugovk, PengZheng, marcinjosinski, JelleZijlstra, and StefanBrand reacted with laugh emoji

@ambvambv changed the title[DO-NOT-MERGE] Debug Azure Pipelines Accept: (see GH-27115)[DO-NOT-MERGE] bpo-44647: Debug Azure Pipelines Accept: (see GH-27115)Jul 15, 2021
@ambvambv changed the title[DO-NOT-MERGE] bpo-44647: Debug Azure Pipelines Accept: (see GH-27115)bpo-44647: Debug Azure Pipelines Accept: (see GH-27115)Jul 15, 2021
@ambvambv changed the titlebpo-44647: Debug Azure Pipelines Accept: (see GH-27115)bpo-44647: Fix test_httpservers failing on Unicode characters in os.environ on Windows (see GH-27115)Jul 15, 2021
@ambvambv changed the titlebpo-44647: Fix test_httpservers failing on Unicode characters in os.environ on Windows (see GH-27115)bpo-44647: Fix test_httpservers failing on Unicode characters in os.environ on WindowsJul 15, 2021
@ambvambv merged commit82b218f intopython:mainJul 15, 2021
@ambvambv deleted the debug-azure-pipelines-accept branchJuly 15, 2021 19:14
@ambvambv added needs backport to 3.9only security fixes needs backport to 3.10only security fixes labelsJul 15, 2021
@miss-islington
Copy link
Contributor

Thanks@ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks@ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-27169 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelJul 15, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 15, 2021
…nviron on Windows (pythonGH-27161)pythonGH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of os.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test.(cherry picked from commit82b218f)Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-botbedevere-bot removed the needs backport to 3.9only security fixes labelJul 15, 2021
@bedevere-bot
Copy link

GH-27170 is a backport of this pull request to the3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 15, 2021
…nviron on Windows (pythonGH-27161)pythonGH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of os.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test.(cherry picked from commit82b218f)Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull requestJul 15, 2021
…nviron on Windows (GH-27161) (#27169)GH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of os.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test.(cherry picked from commit82b218f)Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull requestJul 15, 2021
…nviron on Windows (GH-27161) (#27170)GH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of os.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test.(cherry picked from commit82b218f)Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pablogsalpablogsalpablogsal approved these changes

Assignees
No one assigned
Labels
OS-windowsskip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@ambv@miss-islington@bedevere-bot@pablogsal@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp