NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.8k

bpo-43950: implement on-the-fly source tracking for interactive mode#27117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

isidentical wants to merge1 commit intopython:mainfromisidentical:bpo-43950-source-tracking

Closed

bpo-43950: implement on-the-fly source tracking for interactive mode#27117

isidentical wants to merge1 commit intopython:mainfromisidentical:bpo-43950-source-tracking

Conversation

Copy link

Member

isidentical commentedJul 13, 2021•
edited by bedevere-bot
Loading

Purely for design purposes, do not review/merge.

https://bugs.python.org/issue43950

the-knights-who-say-ni added the CLA signed label

Jul 13, 2021

bedevere-bot added the awaiting core review label

Jul 13, 2021

isidentical added DO-NOT-MERGE skip news labels

Jul 13, 2021

isidentical force-pushed thebpo-43950-source-tracking branch fromd5c62e3 toea92debCompare

July 13, 2021 17:00

bpo-43950: implement on-the-fly source tracking for interactive mode

3d2919c

isidentical force-pushed thebpo-43950-source-tracking branch fromea92deb to3d2919cCompare

July 13, 2021 17:33

Copy link

MemberAuthor

isidentical commentedJul 17, 2021•
edited by bedevere-bot
Loading

One problem with this patch is that, we need to limit fetching from__source__ only for the main frame, otherwise if the offsets match out it will show something like this;

 $ ./pythonPython3.11.0a0 (heads/[bpo-43950](https://bugs.python.org/issue43950)-source-tracking-dirty:1173c11e09,Jul172021,14:52:40) [GCC9.3.0]onlinuxType"help","copyright","credits"or"license"formoreinformation.>>>defframe_3():...return1/0...>>>defframe_2():...returnframe_3()...>>>defframe_1():...returnframe_2()...>>>ifTrue:...1+frame_1()...Traceback (mostrecentcalllast):File"<stdin>",line2,in<module>1+frame_1()^^^^^^^^^File"<stdin>",line2,inframe_11+frame_1()^^^^^^^^^File"<stdin>",line2,inframe_21+frame_1()^^^^^^^^^File"<stdin>",line2,inframe_31+frame_1()^^^ZeroDivisionError:divisionbyzero