Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-38291: Fix a spurious warning when using help(object)#27039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gvanrossum merged 2 commits intopython:mainfromsrittau:typing-io
Jul 6, 2021

Conversation

srittau
Copy link
Contributor

@srittausrittau commentedJul 5, 2021•
edited by miss-islington
Loading

https://bugs.python.org/issue38291

Automerge-Triggered-By: GH:gvanrossum

help(object) via pydoc.TextDoc.docclass(object) iterates over thesubclasses of object, which includes typing.io and typing.re if typingis imported. It tries to access cls.__module__ for each of thosesub-classes. This change suppresses warnings when accessingcls.__module__.
@srittau
Copy link
ContributorAuthor

This should not need a NEWS entry per:

These are the two exceptions:

  1. [...]
  2. If a change is a fix (or other adjustment) to an earlier unreleased change and the original NEWS entry remains valid, then no additional entry is needed.

@srittau
Copy link
ContributorAuthor

The Azure build failure seems unrelated.

@miss-islington
Copy link
Contributor

@srittau: Status check is done, and it's a success ❌ .

@srittau
Copy link
ContributorAuthor

This time, Azure passes, but the address sanitizer(?) test times out. Looks like an unrelated multiprocessing error, possibly a race condition.

@gvanrossum
Copy link
Member

Alas, we have to close and reopen the PR to make the last test pass (hopefully), GitHub won't let me merge without that.

@miss-islington
Copy link
Contributor

@srittau: Status check is done, and it's a success ❌ .

2 similar comments
@miss-islington
Copy link
Contributor

@srittau: Status check is done, and it's a success ❌ .

@miss-islington
Copy link
Contributor

@srittau: Status check is done, and it's a success ❌ .

@gvanrossumgvanrossum merged commit8b849ea intopython:mainJul 6, 2021
@bedevere-bot
Copy link

@gvanrossum: Please replace# withGH- in the commit message next time. Thanks!

@gvanrossum
Copy link
Member

Is a backport needed?

@srittausrittau deleted the typing-io branchJuly 6, 2021 15:27
@srittau
Copy link
ContributorAuthor

srittau commentedJul 6, 2021•
edited
Loading

Thanks and no backport needed, the original change is just in the 3.11branch trunk.

gvanrossum reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes

@ilevkivskyiilevkivskyiAwaiting requested review from ilevkivskyi

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@srittau@miss-islington@gvanrossum@bedevere-bot@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp