NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.8k

bpo-43950: Print columns in tracebacks (PEP 657)#26958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

pablogsal merged 5 commits intopython:mainfromcolnotab:codeobject_changes

Jul 4, 2021

Merged

bpo-43950: Print columns in tracebacks (PEP 657)#26958

pablogsal merged 5 commits intopython:mainfromcolnotab:codeobject_changes

Jul 4, 2021

Conversation

Copy link

Member

ammaraskar commentedJun 29, 2021•
edited
Loading

This pull request implements the relevant bits in traceback printing to utilize the newco_positions andPyCode_Addr2... APIs to print carets for column locations.

All the internal structures, and data representation are subjected to change in future PRs as we add optimizations.

https://bugs.python.org/issue43950

the-knights-who-say-ni added the CLA signed label

Jun 29, 2021

bedevere-bot added the awaiting review label

Jun 29, 2021

ammaraskar added skip news and removed skip news labels

Jun 29, 2021

ammaraskar force-pushed thecodeobject_changes branch 8 times, most recently fromd69a6a4 to6d4302dCompare

July 2, 2021 01:44

ammaraskar changed the title~~bpo-43950: Make compiler output more source offsets.~~bpo-43950: Print columns in tracebacks (PEP 657)

Jul 2, 2021

ammaraskar mentioned this pull request

Jul 2, 2021

bpo-43950: Initial base implementation for PEP 657#26955

Merged

Copy link

Member

pablogsal commentedJul 2, 2021

@ammaraskar Ground control to major tom, commencing countdown engines on

Rebase time!

isidentical reviewed

Jul 2, 2021

View reviewed changes

Python/traceback.c OutdatedShow resolvedHide resolved

isidentical reviewed

Jul 2, 2021

View reviewed changes

Python/traceback.c OutdatedShow resolvedHide resolved

pablogsal marked this pull request as ready for review

July 2, 2021 14:21

pablogsal requested review frombrettcannon,encukou,ericsnowcurrently,markshannon,ncoghlan,terryjreedy,tiran andwarsaw ascode owners

July 2, 2021 14:21

pablogsal force-pushed thecodeobject_changes branch from6d4302d to1fd558cCompare

July 2, 2021 14:21

pablogsal removed request forbrettcannon,encukou andncoghlan

July 2, 2021 14:21

isidentical reviewed

Jul 4, 2021

View reviewed changes

Python/traceback.c OutdatedShow resolvedHide resolved

isidentical reviewed

Jul 4, 2021

View reviewed changes

Python/traceback.c OutdatedShow resolvedHide resolved

isidentical reviewed

Jul 4, 2021

View reviewed changes

Python/traceback.c OutdatedShow resolvedHide resolved

isidentical reviewed

Jul 4, 2021

View reviewed changes

Python/traceback.cShow resolvedHide resolved

Copy link

Member

pablogsal commentedJul 4, 2021

@pablogsal would you mind cleaning up thebyte_to_character_offset_in_line function here.

Yeah, I will do that. Could you address first@isidentical feedback?

ammaraskar mentioned this pull request

Jul 4, 2021

bpo-43950: Add option to opt-out of PEP-657#27023

Merged

Address feedback from@isidentical

9a31711

ammaraskar force-pushed thecodeobject_changes branch from73bcea3 to9a31711Compare

July 4, 2021 19:59

ammaraskarand others added3 commits

July 4, 2021 16:09

Remove TODO about highlighting to end

83f0260

Remove stale TODO

1a5a4cf

Move byte_offset_to_character_offset to the parser API

58e2f7f

pablogsal force-pushed thecodeobject_changes branch 6 times, most recently frome0b1f4b to58e2f7fCompare

July 4, 2021 22:24

pablogsal approved these changes

Jul 4, 2021

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Jul 4, 2021

pablogsal merged commit5644c7b intopython:main

Jul 4, 2021

bedevere-bot removed the awaiting merge label

Jul 4, 2021

pablogsal deleted the codeobject_changes branch

July 4, 2021 23:14

Copy link

Member

pablogsal commentedJul 5, 2021

@ammaraskar Can you open the prs for the follow-ups?

#26958 (comment)

Copy link

MemberAuthor

ammaraskar commentedJul 5, 2021

#27023 for the config change, working on the traceback.py refactor + a bpo issue.

Copy link

MemberAuthor

ammaraskar commentedJul 5, 2021

https://bugs.python.org/issue44569 for the traceback.py change, PR for it coming soon.

pablogsal mentioned this pull request

Apr 13, 2022

Include column offsets for bytecode instructions#88116

Closed

hroncok mentioned this pull request

Jun 18, 2022

support for Python 3.11ipython/ipyparallel#726

Merged

graingert reviewed

Nov 2, 2022

View reviewed changes

Lib/traceback.py

		"""
		iffisNone:
		f=sys._getframe().f_back.f_back
		f=sys._getframe().f_back.f_back.f_back.f_back

Copy link

Contributor

graingertNov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this doesn't seem correct -

Python 3.11.0 | packaged by conda-forge | (main, Oct 25 2022, 06:18:27) [GCC 10.4.0] on linuxType "help", "copyright", "credits" or "license" for more information.>>> import traceback>>> traceback.walk_stack(None)<generator object walk_stack at 0x7f308f4c4700>>>> list(traceback.walk_stack(None))Traceback (most recent call last):  File "<stdin>", line 1, in <module>  File "/home/graingert/anaconda3/envs/dask-distributed-311/lib/python3.11/traceback.py", line 332, in walk_stack    f = sys._getframe().f_back.f_back.f_back.f_back        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AttributeError: 'NoneType' object has no attribute 'f_back'>>>