Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-39452: rewrite and expand __main__.rst#26883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 51 commits intopython:mainfromjdevries3133:bpo-39452__main__docs
Aug 24, 2021

Conversation

jdevries3133
Copy link
Contributor

@jdevries3133jdevries3133 commentedJun 23, 2021•
edited by bedevere-bot
Loading

I am picking up the torch on 39452, continuing where @maggyero left off, and
also implementing
my discourse proposal,
which seemed to be well-liked.

  • __main__docs: intro and first secton
  • bpo-44494: rewrite of Doc/library/__main__.rst (first draft)
  • bpo-44494: add blurb
  • Update __main__.rst
  • Update __main__.rst
  • Take Steven d’Aprano’s review into account
  • Rewrap lines
  • Remove trailing whitespaces

https://bugs.python.org/issue39452

iritkatriel, graingert, and Fidget-Spinner reacted with thumbs up emojidimaqq reacted with heart emoji
@graingert
Copy link
Contributor

graingert commentedJun 29, 2021•
edited
Loading

is it worth mentioning runpy?

@jdevries3133
Copy link
ContributorAuthor

is it work mentioning runpy?

I think so! It's been mentioned; see4c60f2c

@ambv
Copy link
Contributor

OK, at this point I made all the edits I wanted. Look like@merwok did a pass on that already. If I don't hear back by end of day today, I'll be merging that. Huge improvement over the status quo, thanks for your hard work@jdevries3133.

jdevries3133 reacted with hooray emojiholdenweb reacted with heart emojiholdenweb reacted with rocket emoji

@merwok
Copy link
Member

I have noted various small things, but don’t have the time to do an overarching review of all changes.

So I’m glad you picked up my request for review and did an editing pass so that this contribution can be merged! Thanks for your and Jack’s efforts on this!

@ambvambv added the needs backport to 3.10only security fixes labelAug 24, 2021
@ambvambv merged commit7cba231 intopython:mainAug 24, 2021
@miss-islington
Copy link
Contributor

Thanks@jdevries3133 for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@ambv: Please replace# withGH- in the commit message next time. Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 24, 2021
Broadened scope of the document to explicitly discuss and differentiate between ``__main__.py`` in packages versus the ``__name__ == '__main__'`` expression (and the idioms that surround it), as well as ``import __main__``.Co-authored-by: Géry Ogam <gery.ogam@gmail.com>Co-authored-by: Éric Araujo <merwok@netwok.org>Co-authored-by: Łukasz Langa <lukasz@langa.pl>(cherry picked from commit7cba231)Co-authored-by: Jack DeVries <58614260+jdevries3133@users.noreply.github.com>
@bedevere-bot
Copy link

GH-27932 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelAug 24, 2021
@holdenweb
Copy link
Member

holdenweb commentedAug 24, 2021 via email

So cool to see the PSF finally funding development work directly.Kind regards,Steve
…
On Tue, Aug 24, 2021 at 6:01 PM Łukasz Langa ***@***.***> wrote: Merged#26883 <#26883> into main. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#26883 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZWYFBGUIEZOSJ2QMGV73T6PGADANCNFSM47GN2KLQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

miss-islington added a commit that referenced this pull requestAug 24, 2021
Broadened scope of the document to explicitly discuss and differentiate between ``__main__.py`` in packages versus the ``__name__ == '__main__'`` expression (and the idioms that surround it), as well as ``import __main__``.Co-authored-by: Géry Ogam <gery.ogam@gmail.com>Co-authored-by: Éric Araujo <merwok@netwok.org>Co-authored-by: Łukasz Langa <lukasz@langa.pl>(cherry picked from commit7cba231)Co-authored-by: Jack DeVries <58614260+jdevries3133@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@holdenwebholdenwebholdenweb left review comments

@graingertgraingertgraingert approved these changes

@merwokmerwokmerwok left review comments

@mandolaerikmandolaerikmandolaerik left review comments

@Fidget-SpinnerFidget-SpinnerFidget-Spinner left review comments

@pradyunsgpradyunsgpradyunsg requested changes

@ambvambvAwaiting requested review from ambv

Assignees
No one assigned
Labels
docsDocumentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

14 participants
@jdevries3133@graingert@rockobonaparte@yaseppochi@holdenweb@ambv@merwok@miss-islington@bedevere-bot@pradyunsg@mandolaerik@Fidget-Spinner@the-knights-who-say-ni@geryogam
[8]ページ先頭
©2009-2025 Movatter.jp