NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

bpo-38291: Reset DeprecationWarning filters in test_typing io and re#26811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gvanrossum merged 1 commit intopython:mainfromFidget-Spinner:fix-azure-appx

Jun 21, 2021

Merged

bpo-38291: Reset DeprecationWarning filters in test_typing io and re#26811

gvanrossum merged 1 commit intopython:mainfromFidget-Spinner:fix-azure-appx

Jun 21, 2021

Conversation

Copy link

Member

Fidget-Spinner commentedJun 20, 2021•
edited by bedevere-bot
Loading

https://bugs.python.org/issue38291

Reset DeprecationWarning filters in test_typing io and re

5190297

Fidget-Spinner requested review fromgvanrossum andilevkivskyi ascode owners

June 20, 2021 17:27

the-knights-who-say-ni added the CLA signed label

Jun 20, 2021

bedevere-bot added awaiting review testsTests in the Lib/test dir labels

Jun 20, 2021

Fidget-Spinner marked this pull request as draft

June 20, 2021 17:27

Fidget-Spinner changed the title~~Reset DeprecationWarning filters in test_typing io and re~~bpo-38291: Reset DeprecationWarning filters in test_typing io and re

Jun 20, 2021

Fidget-Spinner added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section label

Jun 20, 2021

Copy link

bedevere-bot commentedJun 20, 2021

🤖 New build scheduled with the buildbot fleet by@Fidget-Spinner for commit5190297 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section label

Jun 20, 2021

gvanrossum approved these changes

Jun 21, 2021

View reviewed changes

Copy link

Member

gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I suppose we went too quick here? I’m not sure what this does (it’s been a long time since I played with warnings) but if this is blocking other PRs I am happy to merge it.

bedevere-bot added awaiting merge and removed awaiting review labels

Jun 21, 2021

Fidget-Spinner marked this pull request as ready for review

June 21, 2021 10:02

Copy link

MemberAuthor

Fidget-Spinner commentedJun 21, 2021•
edited
Loading

I suppose we went too quick here? I’m not sure what this does (it’s been a long time since I played with warnings) but if this is blocking other PRs I am happy to merge it.

Luckily this isn't blocking other PRs, buildbot failures only block releases AFAIK. As Sebastian mentioned on the bpo issue, it's an Azure pipelines problem. The specific pipeline is only runafter a commit is made. Even with thetest-with-buildbots label, I'm unable to recreate the conditions for the failure on a PR. At best, this fix is a hunch which I have no way of verifying or reproducing locally.

This fix wasn't clear to me too, until I read this part of the warnings docs:
https://docs.python.org/3/library/warnings.html#testing-warnings