Movatterモバイル変換

serhiy-storchaka requested a review fromrhettinger

June 11, 2021 18:22

the-knights-who-say-ni added the CLA signed label

bedevere-bot added the awaiting core review label

serhiy-storchaka commented

View reviewed changes

Lib/test/test_decimal.py

		self.assertEqual(hashit(value),hashit(int(value)))

		#the same hash that to an int
		self.assertEqual(hashit(Decimal(23)),hashit(23))

Copy link

MemberAuthor

serhiy-storchakaJun 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Covered by tests above.

Lib/test/test_decimal.py

Comment on lines -1822 to -1823

		self.assertTrue(hashit(Decimal('Inf')))
		self.assertTrue(hashit(Decimal('-Inf')))

Copy link

MemberAuthor

serhiy-storchakaJun 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Covered by tests below.

Lib/test/test_decimal.py


		#the same hash that to an int
		self.assertEqual(hashit(Decimal(23)),hashit(23))
		self.assertRaises(TypeError,hash,Decimal('sNaN'))

Copy link

MemberAuthor

serhiy-storchakaJun 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Moved totest_hash_method_nan.

mdickinson approved these changes

View reviewed changes

Copy link

Member

mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

bedevere-bot added awaiting merge and removed awaiting core review labels

serhiy-storchaka merged commit9f1c5f6 intopython:main

bedevere-bot removed the awaiting merge label

serhiy-storchaka deleted the hash-nan branch

June 12, 2021 12:15

serhiy-storchaka added the needs backport to 3.10only security fixes label

Copy link

Contributor

miss-islington commentedJun 13, 2021

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

Copy link

bedevere-bot commentedJun 13, 2021

GH-26706 is a backport of this pull request to the3.10 branch.

bedevere-bot removed the needs backport to 3.10only security fixes label

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

bpo-43475: Fix the Python implementation of hash of Decimal NaN (pyth…

ed58970

…onGH-26679)(cherry picked from commit9f1c5f6)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

miss-islington added a commit that referenced this pull request