Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
Run address sanitiser in the GitHub CI#26640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
markshannon commentedJun 10, 2021
Looks like you've found an X11 bug. |
markshannon commentedJun 10, 2021
I'd exclude the failing tests for now and add a note somewhere to revisit the exclusions in a month or two. |
.github/workflows/build.yml Outdated
| - name: Display build info | ||
| run: make pythoninfo | ||
| - name: Tests | ||
| run: xvfb-run make buildbottest TESTOPTS="-j4 -uall,-cpu -x test_ctypes test_capi test_crypt test_decimal test_faulthandler test_interpreters" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Addtest___all__ test_idle test_tix test_tk test_ttk_guionly test_ttk_textonly to this list.
Uh oh!
There was an error while loading.Please reload this page.
vstinner commentedJun 10, 2021
Rather than putting |
pablogsal commentedJun 10, 2021
👍 Makes sense, that's clearly a better option |
markshannon commentedJun 10, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
pablogsal commentedJun 10, 2021
Yeah, that makes sense, although it may be worth to also addsome option so you can easily run this locally. I think we should also add something to the devguide about what is excluded and why. In any case, I am going to merge this and add the option to regrtest in a separate PR. |
vstinner commentedJun 11, 2021
My concern is that there is also an ASAN buildbot, and this denylist is copied manually. It increases the maintenance burden. Well, since@pablogsal runs the buildbot, he is likely eagger to maintain these two lists manually ;-) Maybe an option is not needed, and regrtest could detected if Python was built with ASAN using sysconfig to get compiler flags.
Sure, it would be great to skip less tests ;-) |
No description provided.