Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the test suite#26542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pablogsal merged 2 commits intopython:mainfrompablogsal:bpo-38323
Jun 4, 2021

Conversation

@pablogsal
Copy link
Member

@pablogsalpablogsal commentedJun 4, 2021•
edited by bedevere-bot
Loading

@pablogsal
Copy link
MemberAuthor

@cjerdonek could you take a look?

Copy link
Member

@cjerdonekcjerdonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah, that looks fine.

@pablogsalpablogsal merged commitf171877 intopython:mainJun 4, 2021
@pablogsalpablogsal deleted the bpo-38323 branchJune 4, 2021 23:33
@miss-islington
Copy link
Contributor

Thanks@pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry@pablogsal, I had trouble checking out the3.10 backport branch.
Please backport usingcherry_picker on command line.
cherry_picker f171877ebe276749f31386baed5841ce37cbee2e 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 4, 2021
…est suite (pythonGH-26542)(cherry picked from commitf171877)Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot
Copy link

GH-26543 is a backport of this pull request to the3.9 branch.

@pablogsalpablogsal added needs backport to 3.10only security fixes and removed needs backport to 3.10only security fixes labelsJun 4, 2021
@miss-islington
Copy link
Contributor

Thanks@pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelJun 4, 2021
@bedevere-bot
Copy link

GH-26544 is a backport of this pull request to the3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 4, 2021
…est suite (pythonGH-26542)(cherry picked from commitf171877)Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull requestJun 5, 2021
…est suite (GH-26542)(cherry picked from commitf171877)Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull requestJun 5, 2021
…est suite (GH-26542) (GH-26544)(cherry picked from commitf171877)Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@vstinner
Copy link
Member

vstinner commentedJun 7, 2021•
edited by bedevere-bot
Loading

 @unittest.skip("[bpo-38323](https://bugs.python.org/issue38323): MultiLoopChildWatcher has a race condition

FYI if a skip message contains "bpo-xxx", a buildbot fails when a PR is merged and the buildbot logs contain the skip message, the PR will be attached to bpo-xxx.

IMO the bot attaching PRs to bpo issues should only look into the PR title, not in PR comments.

@pablogsal
Copy link
MemberAuthor

FYI if a skip message contains "bpo-xxx", a buildbot fails when a PR is merged and the buildbot logs contain the skip message, the PR will be attached to bpo-xxx.

Well, hopefully soon we can merge some form of your PR and then remove that skip :)

@miss-islington
Copy link
Contributor

Thanks@pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-26670 is a backport of this pull request to the3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 11, 2021
…est suite (pythonGH-26542)(cherry picked from commitf171877)Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull requestJun 12, 2021
…est suite (GH-26542) (GH-26670)(cherry picked from commitf171877)Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cjerdonekcjerdonekcjerdonek approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

Assignees

@pablogsalpablogsal

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pablogsal@miss-islington@bedevere-bot@vstinner@cjerdonek@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp